Issue 10354005: Fix for Issue 2878

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10354005: Fix for Issue 2878 (Closed)

Created:
8 years, 7 months ago by sra1

Modified:
8 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl, vsm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for Issue 2878 Make sure we use a common root name for getters (setters) even when the members have different jsnames due to native renames. Committed: https://code.google.com/p/dart/source/detail?r=7294

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : rebase #

Patch Set 4 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -37 lines)			Patch
M	frog/gen.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	frog/member.dart	View		3 chunks	+11 lines, -1 line	0 comments	Download
M	frog/member_set.dart	View		4 chunks	+17 lines, -10 lines	0 comments	Download
A	frog/tests/frog_native/native_field_rename_1_frog_test.dart	View	1	1 chunk	+79 lines, -0 lines	0 comments	Download
A	frog/tests/frog_native/native_field_rename_2_frog_test.dart	View	1	1 chunk	+93 lines, -0 lines	0 comments	Download
M	frog/world.dart	View		2 chunks	+5 lines, -23 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

Please let me know if you can't review this today. It is a second-level blocker ...

8 years, 7 months ago (2012-05-03 03:56:13 UTC) #1

LGTM

Expand Messages | Collapse Messages