Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5230)

Unified Diff: chrome/browser/instant/instant_field_trial.h

Issue 10353017: Unlaunch the HIDDEN mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed @sky's comment; fixed tests Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/instant/instant_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_field_trial.h
diff --git a/chrome/browser/instant/instant_field_trial.h b/chrome/browser/instant/instant_field_trial.h
index a6f390d00bdc9a5f032b9fe1f01aaa257819059f..2dca72ce20afc0854cd4932420a0c5ab4425932f 100644
--- a/chrome/browser/instant/instant_field_trial.h
+++ b/chrome/browser/instant/instant_field_trial.h
@@ -11,19 +11,10 @@
class Profile;
-// This class manages the Instant field trial.
+// This class manages the Instant field trial, which is in one of these modes:
//
-// If a user (profile) has an explicit preference for Instant, having disabled
-// or enabled it in the Preferences page, or by having a group policy override,
-// the field trial is INACTIVE for them. There is no change in behaviour. Their
-// Instant preference is respected. Incognito profiles are also INACTIVE.
-//
-// The following mutually exclusive groups each select a small random sample of
-// the remaining users. Instant is enabled with preloading of the search engine
-// homepage for all the experiment groups. It remains disabled, as is default,
-// for the CONTROL group.
-//
-// INSTANT: Queries are issued as the user types. Predicted query is inline
+// INSTANT: The default search engine is preloaded when the omnibox gets focus.
+// Queries are issued as the user types. Predicted queries are inline
// autocompleted into the omnibox. Result previews are shown.
//
// SUGGEST: Same as INSTANT, without the previews.
@@ -34,12 +25,9 @@ class Profile;
// is sent only after the user presses <Enter>.
//
// CONTROL: Instant is disabled.
-//
-// Users not chosen into any of the above groups are INACTIVE.
class InstantFieldTrial {
public:
- enum Group {
- INACTIVE,
+ enum Mode {
INSTANT,
SUGGEST,
HIDDEN,
@@ -47,32 +35,19 @@ class InstantFieldTrial {
CONTROL
};
- // Activate the field trial. Before this call, all calls to GetGroup will
- // return INACTIVE. *** MUST NOT BE CALLED MORE THAN ONCE. ***
+ // Activate the field trial and choose a mode at random. Without this, most
+ // calls to GetMode() will return CONTROL. See GetMode() for more details.
+ // *** MUST NOT BE CALLED MORE THAN ONCE. ***
static void Activate();
- // Return the field trial group this profile belongs to.
- static Group GetGroup(Profile* profile);
-
- // Check if the user is in any of the experiment groups.
- static bool IsInstantExperiment(Profile* profile);
-
- // Check if the user is in the SUGGEST, HIDDEN or SILENT groups.
- static bool IsHiddenExperiment(Profile* profile);
-
- // Check if the user is in the SILENT group.
- static bool IsSilentExperiment(Profile* profile);
-
- // Returns a string describing the user's group. Can be added to histogram
- // names, to split histograms by field trial groups.
- static std::string GetGroupName(Profile* profile);
-
- // Returns a string denoting the user's group, for adding as a URL param.
- static std::string GetGroupAsUrlParam(Profile* profile);
+ // Return the field trial mode for this profile. This will usually be the
+ // mode selected by Activate(), but can sometimes be different, depending on
+ // the profile. See the implementation in the .cc file for specific details.
+ static Mode GetMode(Profile* profile);
- // Returns whether the Instant suggested text should be autocompleted inline
- // into the omnibox.
- static bool ShouldSetSuggestedText(Profile* profile);
+ // Return a string describing the mode. Can be added to histogram names, to
+ // split histograms by modes.
+ static std::string GetModeAsString(Profile* profile);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(InstantFieldTrial);
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/instant/instant_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698