Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/autocomplete/autocomplete.cc

Issue 10353017: Unlaunch the HIDDEN mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed @sky's comment; fixed tests Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/instant/instant_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autocomplete/autocomplete.h" 5 #include "chrome/browser/autocomplete/autocomplete.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <set> 9 #include <set>
10 10
(...skipping 914 matching lines...) Expand 10 before | Expand all | Expand 10 after
925 for (ACProviders::iterator i(providers_.begin()); i != providers_.end(); 925 for (ACProviders::iterator i(providers_.begin()); i != providers_.end();
926 ++i) { 926 ++i) {
927 (*i)->Start(input_, minimal_changes); 927 (*i)->Start(input_, minimal_changes);
928 if (matches_requested != AutocompleteInput::ALL_MATCHES) 928 if (matches_requested != AutocompleteInput::ALL_MATCHES)
929 DCHECK((*i)->done()); 929 DCHECK((*i)->done());
930 } 930 }
931 if (matches_requested == AutocompleteInput::ALL_MATCHES && 931 if (matches_requested == AutocompleteInput::ALL_MATCHES &&
932 (text.length() < 6)) { 932 (text.length() < 6)) {
933 base::TimeTicks end_time = base::TimeTicks::Now(); 933 base::TimeTicks end_time = base::TimeTicks::Now();
934 std::string name = "Omnibox.QueryTime." + base::IntToString(text.length()) + 934 std::string name = "Omnibox.QueryTime." + base::IntToString(text.length()) +
935 InstantFieldTrial::GetGroupName(profile_); 935 InstantFieldTrial::GetModeAsString(profile_);
936 base::Histogram* counter = base::Histogram::FactoryGet( 936 base::Histogram* counter = base::Histogram::FactoryGet(
937 name, 1, 1000, 50, base::Histogram::kUmaTargetedHistogramFlag); 937 name, 1, 1000, 50, base::Histogram::kUmaTargetedHistogramFlag);
938 counter->Add(static_cast<int>((end_time - start_time).InMilliseconds())); 938 counter->Add(static_cast<int>((end_time - start_time).InMilliseconds()));
939 } 939 }
940 in_start_ = false; 940 in_start_ = false;
941 CheckIfDone(); 941 CheckIfDone();
942 UpdateResult(true); 942 UpdateResult(true);
943 943
944 if (!done_) 944 if (!done_)
945 StartExpireTimer(); 945 StartExpireTimer();
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
1140 : text(text), 1140 : text(text),
1141 input_type(input_type), 1141 input_type(input_type),
1142 selected_index(selected_index), 1142 selected_index(selected_index),
1143 tab_id(tab_id), 1143 tab_id(tab_id),
1144 current_page_classification(current_page_classification), 1144 current_page_classification(current_page_classification),
1145 elapsed_time_since_user_first_modified_omnibox( 1145 elapsed_time_since_user_first_modified_omnibox(
1146 elapsed_time_since_user_first_modified_omnibox), 1146 elapsed_time_since_user_first_modified_omnibox),
1147 inline_autocompleted_length(inline_autocompleted_length), 1147 inline_autocompleted_length(inline_autocompleted_length),
1148 result(result) { 1148 result(result) {
1149 } 1149 }
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/instant/instant_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698