Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: lib/compiler/implementation/ssa/codegen_helpers.dart

Issue 10353014: Start implementing checked mode and tools support for using it. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen_helpers.dart
===================================================================
--- lib/compiler/implementation/ssa/codegen_helpers.dart (revision 7371)
+++ lib/compiler/implementation/ssa/codegen_helpers.dart (working copy)
@@ -42,10 +42,6 @@
}
}
- void visitTypeConversion(HTypeConversion instruction) {
- generateAtUseSite.add(instruction);
- }
-
// The codegen might use the input multiple times, so it must not be
// set generate at use site.
void visitIs(HIs instruction) {}
@@ -58,6 +54,10 @@
// they would not be alive.
void visitTypeGuard(HTypeGuard instruction) {}
+ // TODO(ngeoffray): This should not be needed. The codegen should
+ // cope better with this instruction.
+ void visitTypeConversion(HTypeConversion instruction) {}
+
void tryGenerateAtUseSite(HInstruction instruction) {
// A type guard should never be generate at use site, otherwise we
// cannot bailout.
@@ -67,6 +67,10 @@
// cannot throw.
if (instruction is HCheck) return;
+ // TODO(ngeoffray): This should not be needed. The codegen should
+ // cope better with this instruction.
+ if (instruction is HTypeConversion) return;
+
generateAtUseSite.add(instruction);
}
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698