Split nodes and edges into separate arrays in heap profiler.

src/profile-generator-inl.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 78 matching lines @@
     // one bucket.
     case OTHER:
     case EXTERNAL:
       return program_entry_;
     default: return NULL;
   }
 }
 
 
 HeapEntry* HeapGraphEdge::from() const {
-  return const_cast<HeapEntry*>(
-      reinterpret_cast<const HeapEntry*>(this - child_index_) - 1);
+  return &snapshot()->entries()[from_];
 }
 
 
+HeapSnapshot* HeapGraphEdge::snapshot() const {
+  return to_entry_->snapshot();
+}
+
+
+int HeapEntry::index() const {
+  return this - &snapshot_->entries().first();

[mnaganov (inactive), 2012/05/03 15:44:31]

I'm not sure this will compile on all platforms. Have you checked Win64 for
example?

[alexeif, 2012/05/07 11:04:35]

I'm not sure, as I don't have a Windows machine. I added a cast anyway.

+}
+
+
+HeapGraphEdge** HeapEntry::children_arr() {
+  ASSERT(children_index_ >= 0);
+  return &snapshot_->children()[children_index_];
+}
+
+
+HeapGraphEdge** HeapEntry::retainers_arr() {
+  ASSERT(retainers_index_ >= 0);
+  return &snapshot_->retainers()[retainers_index_];
+}
+
+
+HeapEntry* HeapEntry::dominator() const {
+  ASSERT(dominator_ >= 0);
+  return &snapshot_->entries()[dominator_];
+}
+
+
 SnapshotObjectId HeapObjectsMap::GetNthGcSubrootId(int delta) {
   return kGcRootsFirstSubrootId + delta * kObjectIdStep;
 }
 
 
 HeapObject* V8HeapExplorer::GetNthGcSubrootObject(int delta) {
   return reinterpret_cast<HeapObject*>(
       reinterpret_cast<char*>(kFirstGcSubrootObject) +
       delta * HeapObjectsMap::kObjectIdStep);
 }
 
 
 int V8HeapExplorer::GetGcSubrootOrder(HeapObject* subroot) {
   return static_cast<int>(
       (reinterpret_cast<char*>(subroot) -
        reinterpret_cast<char*>(kFirstGcSubrootObject)) /
       HeapObjectsMap::kObjectIdStep);
 }
 
 } }  // namespace v8::internal
 
 #endif  // V8_PROFILE_GENERATOR_INL_H_