Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: ui/web_dialogs/web_dialog_ui.cc

Issue 10353007: Extract a minimal subset of WebDialogUI/WebDialogDelegate from src/chrome -> src/ui/web_dialogs Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/web_dialogs/web_dialog_ui.cc
===================================================================
--- ui/web_dialogs/web_dialog_ui.cc (revision 0)
+++ ui/web_dialogs/web_dialog_ui.cc (revision 0)
@@ -0,0 +1,125 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/web_dialogs/web_dialog_delegate.h"
+#include "ui/web_dialogs/web_dialog_ui.h"
mazda 2012/05/04 05:01:38 Please move this to the top.
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/lazy_instance.h"
+#include "base/property_bag.h"
+#include "base/values.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_ui.h"
+#include "content/public/browser/web_ui_message_handler.h"
+#include "content/public/common/bindings_policy.h"
+#include "ui/web_dialogs/web_dialog_notification_types.h"
+
+using content::RenderViewHost;
+using content::WebUIMessageHandler;
+
+namespace web_dialogs {
+
+static base::LazyInstance<base::PropertyAccessor<WebDialogDelegate*> >
+ g_web_dialog_ui_property_accessor = LAZY_INSTANCE_INITIALIZER;
+
+WebDialogUI::WebDialogUI(content::WebUI* web_ui)
+ : WebUIController(web_ui) {
+}
+
+WebDialogUI::~WebDialogUI() {
+ // Don't unregister our property. During the teardown of the WebContents,
+ // this will be deleted, but the WebContents will already be destroyed.
+ //
+ // This object is owned indirectly by the WebContents. WebUIs can change, so
+ // it's scary if this WebUI is changed out and replaced with something else,
+ // since the property will still point to the old delegate. But the delegate
+ // is itself the owner of the WebContents for a dialog so will be in scope,
+ // and the HTML dialogs won't swap WebUIs anyway since they don't navigate.
+}
+
+void WebDialogUI::CloseDialog(const base::ListValue* args) {
+ OnDialogClosed(args);
+}
+
+// static
+base::PropertyAccessor<WebDialogDelegate*>& WebDialogUI::GetPropertyAccessor() {
+ return g_web_dialog_ui_property_accessor.Get();
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// Private:
+
+void WebDialogUI::RenderViewCreated(RenderViewHost* render_view_host) {
+ // Hook up the javascript function calls, also known as chrome.send("foo")
+ // calls in the HTML, to the actual C++ functions.
+ web_ui()->RegisterMessageCallback("DialogClose",
+ base::Bind(&WebDialogUI::OnDialogClosed, base::Unretained(this)));
+
+ // Pass the arguments to the renderer supplied by the delegate.
+ std::string dialog_args;
+ std::vector<WebUIMessageHandler*> handlers;
+ WebDialogDelegate** delegate = GetPropertyAccessor().GetProperty(
+ web_ui()->GetWebContents()->GetPropertyBag());
+ if (delegate) {
+ dialog_args = (*delegate)->GetDialogArgs();
+ (*delegate)->GetWebUIMessageHandlers(&handlers);
+ }
+
+ if (0 != (web_ui()->GetBindings() & content::BINDINGS_POLICY_WEB_UI))
+ render_view_host->SetWebUIProperty("dialogArguments", dialog_args);
+ for (std::vector<WebUIMessageHandler*>::iterator it = handlers.begin();
+ it != handlers.end(); ++it) {
+ web_ui()->AddMessageHandler(*it);
+ }
+
+ content::NotificationService::current()->Notify(
+ web_dialogs::NOTIFICATION_WEB_DIALOG_SHOWN,
+ content::Source<content::WebUI>(web_ui()),
+ content::Details<RenderViewHost>(render_view_host));
+}
+
+void WebDialogUI::OnDialogClosed(const ListValue* args) {
+ WebDialogDelegate** delegate = GetPropertyAccessor().GetProperty(
+ web_ui()->GetWebContents()->GetPropertyBag());
+ if (delegate) {
+ std::string json_retval;
+ if (args && !args->empty() && !args->GetString(0, &json_retval))
+ NOTREACHED() << "Could not read JSON argument";
+
+ (*delegate)->OnDialogClosed(json_retval);
+ }
+}
+
+std::string WebDialogDelegate::GetDialogName() const {
+ return std::string();
+}
+
+void WebDialogDelegate::GetMinimumDialogSize(gfx::Size* size) const {
+ GetDialogSize(size);
+}
+
+bool WebDialogDelegate::HandleContextMenu(
+ const content::ContextMenuParams& params) {
+ return false;
+}
+
+bool WebDialogDelegate::HandleOpenURLFromTab(
+ content::WebContents* source,
+ const content::OpenURLParams& params,
+ content::WebContents** out_new_contents) {
+ return false;
+}
+
+bool WebDialogDelegate::HandleAddNewContents(
+ content::WebContents* source,
+ content::WebContents* new_contents,
+ WindowOpenDisposition disposition,
+ const gfx::Rect& initial_pos,
+ bool user_gesture) {
+ return false;
+}
+} // namespace web_dialogs

Powered by Google App Engine
This is Rietveld 408576698