chrome/browser/ui/views/web_dialog_view_browsertest.cc - Issue 10353007: Extract a minimal subset of WebDialogUI/WebDialogDelegate from src/chrome -> src/ui/web_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/web_dialog_view_browsertest.cc

Issue 10353007: Extract a minimal subset of WebDialogUI/WebDialogDelegate from src/chrome -> src/ui/web_dialogs Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_dialogs.h ('K') | « chrome/browser/ui/views/web_dialog_view.cc ('k') | chrome/browser/ui/webui/chrome_web_dialog_web_contents_delegate.h » ('j') | chrome/browser/ui/webui/external_web_dialog_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/web_dialog_view_browsertest.cc

===================================================================

--- chrome/browser/ui/views/web_dialog_view_browsertest.cc (revision 135175)

+++ chrome/browser/ui/views/web_dialog_view_browsertest.cc (working copy)

@@ -186,7 +186,7 @@

// This is timing out about 5~10% of runs. See crbug.com/86059.

IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, DISABLED_WebContentRendered) {

- WebDialogDelegate* delegate = new test::TestWebDialogDelegate(

+ web_dialogs::WebDialogDelegate* delegate = new test::TestWebDialogDelegate(

GURL(chrome::kChromeUIChromeURLsURL));

TestWebDialogView* view =