chrome/browser/ui/browser.h - Issue 10353007: Extract a minimal subset of WebDialogUI/WebDialogDelegate from src/chrome -> src/ui/web_dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.h

Issue 10353007: Extract a minimal subset of WebDialogUI/WebDialogDelegate from src/chrome -> src/ui/web_dialogs Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/printing/cloud_print/cloud_print_setup_flow.h ('K') | « chrome/browser/printing/print_preview_tab_controller.cc ('k') | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/browser_dialogs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.h

===================================================================

--- chrome/browser/ui/browser.h (revision 135175)

+++ chrome/browser/ui/browser.h (working copy)

@@ -70,7 +70,10 @@

class TabNavigation;

class TabStripModel;

struct WebApplicationInfo;

+namespace web_dialogs {

mazda 2012/05/04 05:01:38 Please move this below gfx.

class WebDialogDelegate;

namespace content {

class NavigationController;

@@ -491,8 +494,9 @@

// is the window that should be parent of the dialog, or NULL for the default.

// |style| customizes this HTML dialog decoration and layout (X button,

// throbber, default content padding).

- gfx::NativeWindow BrowserShowWebDialog(WebDialogDelegate* delegate,

- gfx::NativeWindow parent_window);

+ gfx::NativeWindow

+ BrowserShowWebDialog(web_dialogs::WebDialogDelegate* delegate,

+ gfx::NativeWindow parent_window);

// Called when a popup select is about to be displayed.

void BrowserRenderWidgetShowing();