Change Platform members to getters instead of methods.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 577 matching lines @@
         while ('${tempDir.path}/../$htmlFilename'.length >= 260) {
           htmlFilename = htmlFilename.substring(htmlFilename.length~/2);
         }
         htmlPath = '${tempDir.path}/../$htmlFilename';
       }
       final String scriptPath = (compiler == 'none') ?
           dartWrapperFilename : compiledDartWrapperFilename;
       // Create the HTML file for the test.
       RandomAccessFile htmlTest = new File(htmlPath).openSync(FileMode.WRITE);
       String filePrefix = '';
-      if (Platform.operatingSystem() == 'windows') {
+      if (Platform.operatingSystem == 'windows') {
         // Firefox on Windows does not like absolute file path names that start
         // with 'C:' adding 'file:///' solves the problem.
         filePrefix = 'file:///';
       }
       htmlTest.writeStringSync(GetHtmlContents(
           filename,
           '$filePrefix$dartDir/lib/unittest/test_controller.js',
           scriptType,
           filePrefix + scriptPath));
       htmlTest.closeSync();
@@ skipping 200 matching lines @@
   String getHtmlName(String filename) {
     return filename.replaceAll('/', '_').replaceAll(':', '_')
         .replaceAll('\\', '_') + configuration['compiler'] + '-' +
         configuration['runtime'] + '.html';
   }
 
   String get dumpRenderTreeFilename() {
     if (configuration['drt'] != '') {
       return configuration['drt'];
     }
-    if (Platform.operatingSystem() == 'macos') {
+    if (Platform.operatingSystem == 'macos') {
       return '$dartDir/client/tests/drt/DumpRenderTree.app/Contents/'
           'MacOS/DumpRenderTree';
     }
     return '$dartDir/client/tests/drt/DumpRenderTree';
   }
 
   String get dartiumFilename() {
     if (configuration['dartium'] != '') {
       return configuration['dartium'];
     }
-    if (Platform.operatingSystem() == 'macos') {
+    if (Platform.operatingSystem == 'macos') {
       return '$dartDir/client/tests/dartium/Chromium.app/Contents/'
           'MacOS/Chromium';
     }
     return '$dartDir/client/tests/dartium/chrome';
   }
 
   void testGeneratorStarted() {
     ++activeTestGenerators;
   }
 
@@ skipping 372 matching lines @@
    * Assumes that the directory for [dest] already exists.
    */
   static void copyFile(File source, File dest) {
     List contents = source.readAsBytesSync();
     RandomAccessFile handle = dest.openSync(FileMode.WRITE);
     handle.writeListSync(contents, 0, contents.length);
     handle.closeSync();
   }
 
   static String executableSuffix(String executable) {
-    if (Platform.operatingSystem() == 'windows') {
+    if (Platform.operatingSystem == 'windows') {
       if (executable == 'd8' || executable == 'vm' || executable == 'none') {
         return '.exe';
       } else {
         return '.bat';
       }
     }
     return '';
   }
 
   static String executableName(Map configuration) {
@@ skipping 165 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }