Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 10348005: Revert 135077 - Files generated by the JSON schema compiler are named incorrectly (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 7 months ago
Reviewers:
cduvall
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 135077 - Files generated by the JSON schema compiler are named incorrectly Files are now named like "file_name.h" instead of "fileName.h" or "file.name.h" BUG=125669 TEST=All previous tests for the renamed files This broke Linux and Linux64: g++: out/Release/obj/gen/chrome/common/extensions/api/experimental.fontSettings.cc: No such file or directory g++: no input files make: *** [out/Release/obj.target/api/gen/chrome/common/extensions/api/experimental.fontSettings.o] Error 1 Review URL: http://codereview.chromium.org/10272021 TBR=cduvall@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/extensions/api/alarms/alarm_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/alarms/alarms_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dns/dns_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/usb/usb_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/compiler.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tfarina
8 years, 7 months ago (2012-05-03 03:35:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698