Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 10348002: ugrr... Fixing printing scaling again. (Closed)

Created:
8 years, 7 months ago by gene
Modified:
8 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

ugrr... Fixing printing scaling again. Not the nicest fix, but it should do the job. Now, we'll try to use default scaling (72dpi) whenever we can. If sceen resolution droped below the point where metafile can't accomodate whole PDF page anymore, we'll use this hack to pass custom scale in the TLS for the upper layer. BUG=125499 TEST=Print PDF using print preview and system print dialog. Same for webpage. Make screen resolution 800x600 and repeat. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135241

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -35 lines) Patch
M chrome/renderer/print_web_view_helper_win.cc View 1 2 3 2 chunks +32 lines, -33 lines 0 comments Download
A printing/custom_scaling.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
A printing/custom_scaling.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download
M printing/printing.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gene
Please make sure it is ok calling printing/* from ppapi_plugin_instance. Looks like we are doing ...
8 years, 7 months ago (2012-05-02 23:25:29 UTC) #1
Albert Bodenhamer
On 2012/05/02 23:25:29, gene wrote: > Please make sure it is ok calling printing/* from ...
8 years, 7 months ago (2012-05-02 23:31:28 UTC) #2
Albert Bodenhamer
lgtm https://chromiumcodereview.appspot.com/10348002/diff/3002/chrome/renderer/print_web_view_helper_win.cc File chrome/renderer/print_web_view_helper_win.cc (right): https://chromiumcodereview.appspot.com/10348002/diff/3002/chrome/renderer/print_web_view_helper_win.cc#newcode127 chrome/renderer/print_web_view_helper_win.cc:127: // TODO(gene): We should revisit this solution for ...
8 years, 7 months ago (2012-05-02 23:49:18 UTC) #3
gene
created new issue as suggested (https://code.google.com/p/chromium/issues/detail?id=126037) referenced it in the TODO feel free to take ...
8 years, 7 months ago (2012-05-03 00:15:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10348002/3005
8 years, 7 months ago (2012-05-03 00:22:22 UTC) #5
commit-bot: I haz the power
Presubmit check for 10348002-3005 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-03 00:22:32 UTC) #6
gene
As an OWNER of PPAPI could you please take a look? This is a bad ...
8 years, 7 months ago (2012-05-03 17:21:08 UTC) #7
brettw
webkit LGTM
8 years, 7 months ago (2012-05-03 20:50:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gene@chromium.org/10348002/3005
8 years, 7 months ago (2012-05-03 20:51:36 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-03 23:53:31 UTC) #10
Change committed as 135241

Powered by Google App Engine
This is Rietveld 408576698