Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 10347002: Add a simple UMA for counting web intents dispatches. (Closed)

Created:
8 years, 7 months ago by Greg Billock
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add a simple UMA for counting web intents dispatches. R=jhawkins@chromium.org BUG=111978 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138342

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge to head #

Patch Set 3 : Merge to head #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Greg Billock
8 years, 7 months ago (2012-05-02 18:48:14 UTC) #1
James Hawkins
https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/browser.cc#newcode4004 chrome/browser/ui/browser.cc:4004: UMA_HISTOGRAM_COUNTS("WebIntents.Dispatch", 1); Are you familiar with all the other ...
8 years, 7 months ago (2012-05-02 20:03:00 UTC) #2
Greg Billock
https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/browser.cc#newcode4004 chrome/browser/ui/browser.cc:4004: UMA_HISTOGRAM_COUNTS("WebIntents.Dispatch", 1); No. I looked for details, but didn't ...
8 years, 7 months ago (2012-05-02 20:11:54 UTC) #3
Greg Billock
On 2012/05/02 20:11:54, Greg Billock wrote: > https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/browser.cc > File chrome/browser/ui/browser.cc (right): > > https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/browser.cc#newcode4004 ...
8 years, 7 months ago (2012-05-07 18:50:32 UTC) #4
James Hawkins
On 2012/05/07 18:50:32, Greg Billock wrote: > On 2012/05/02 20:11:54, Greg Billock wrote: > > ...
8 years, 7 months ago (2012-05-07 20:23:56 UTC) #5
Greg Billock
On 2012/05/07 20:23:56, James Hawkins wrote: > On 2012/05/07 18:50:32, Greg Billock wrote: > > ...
8 years, 7 months ago (2012-05-08 02:29:53 UTC) #6
James Hawkins
I'm not sure this is valuable data. What do we have to compare it against?
8 years, 7 months ago (2012-05-10 00:51:26 UTC) #7
Greg Billock
On 2012/05/10 00:51:26, James Hawkins wrote: > I'm not sure this is valuable data. What ...
8 years, 7 months ago (2012-05-14 15:07:27 UTC) #8
James Hawkins
On 2012/05/14 15:07:27, Greg Billock wrote: > On 2012/05/10 00:51:26, James Hawkins wrote: > > ...
8 years, 7 months ago (2012-05-14 17:26:49 UTC) #9
Greg Billock
On 2012/05/14 17:26:49, James Hawkins wrote: > On 2012/05/14 15:07:27, Greg Billock wrote: > > ...
8 years, 7 months ago (2012-05-15 20:11:35 UTC) #10
Peter Kasting
Rubber-stamp LGTM
8 years, 7 months ago (2012-05-21 19:05:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10347002/14001
8 years, 7 months ago (2012-05-21 19:07:29 UTC) #12
commit-bot: I haz the power
Try job failure for 10347002-14001 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 7 months ago (2012-05-21 23:06:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10347002/14001
8 years, 7 months ago (2012-05-21 23:14:56 UTC) #14
commit-bot: I haz the power
Try job failure for 10347002-14001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 01:40:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10347002/14001
8 years, 7 months ago (2012-05-22 14:04:41 UTC) #16
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 17:42:58 UTC) #17
Try job failure for 10347002-14001 (retry) (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698