|
|
Created:
8 years, 7 months ago by Greg Billock Modified:
8 years, 7 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd a simple UMA for counting web intents dispatches.
R=jhawkins@chromium.org
BUG=111978
TEST=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138342
Patch Set 1 #
Total comments: 2
Patch Set 2 : Merge to head #Patch Set 3 : Merge to head #Patch Set 4 : Rebase #Messages
Total messages: 17 (0 generated)
https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... File chrome/browser/ui/browser.cc (right): https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... chrome/browser/ui/browser.cc:4004: UMA_HISTOGRAM_COUNTS("WebIntents.Dispatch", 1); Are you familiar with all the other requirements you need to fulfill to add a histogram?
https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... File chrome/browser/ui/browser.cc (right): https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... chrome/browser/ui/browser.cc:4004: UMA_HISTOGRAM_COUNTS("WebIntents.Dispatch", 1); No. I looked for details, but didn't find them, so I figured this way I'd learn. :-) On 2012/05/02 20:03:00, James Hawkins wrote: > Are you familiar with all the other requirements you need to fulfill to add a > histogram?
On 2012/05/02 20:11:54, Greg Billock wrote: > https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... > File chrome/browser/ui/browser.cc (right): > > https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... > chrome/browser/ui/browser.cc:4004: UMA_HISTOGRAM_COUNTS("WebIntents.Dispatch", > 1); > No. I looked for details, but didn't find them, so I figured this way I'd learn. > :-) > > On 2012/05/02 20:03:00, James Hawkins wrote: > > Are you familiar with all the other requirements you need to fulfill to add a > > histogram? Server-side change submitted.
On 2012/05/07 18:50:32, Greg Billock wrote: > On 2012/05/02 20:11:54, Greg Billock wrote: > > > https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... > > File chrome/browser/ui/browser.cc (right): > > > > > https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... > > chrome/browser/ui/browser.cc:4004: UMA_HISTOGRAM_COUNTS("WebIntents.Dispatch", > > 1); > > No. I looked for details, but didn't find them, so I figured this way I'd > learn. > > :-) > > > > On 2012/05/02 20:03:00, James Hawkins wrote: > > > Are you familiar with all the other requirements you need to fulfill to add > a > > > histogram? > > Server-side change submitted. Link?
On 2012/05/07 20:23:56, James Hawkins wrote: > On 2012/05/07 18:50:32, Greg Billock wrote: > > On 2012/05/02 20:11:54, Greg Billock wrote: > > > > > > https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... > > > File chrome/browser/ui/browser.cc (right): > > > > > > > > > https://chromiumcodereview.appspot.com/10347002/diff/1/chrome/browser/ui/brow... > > > chrome/browser/ui/browser.cc:4004: > UMA_HISTOGRAM_COUNTS("WebIntents.Dispatch", > > > 1); > > > No. I looked for details, but didn't find them, so I figured this way I'd > > learn. > > > :-) > > > > > > On 2012/05/02 20:03:00, James Hawkins wrote: > > > > Are you familiar with all the other requirements you need to fulfill to > add > > a > > > > histogram? > > > > Server-side change submitted. > > Link? https://chromereviews.googleplex.com/4453013/
I'm not sure this is valuable data. What do we have to compare it against?
On 2012/05/10 00:51:26, James Hawkins wrote: > I'm not sure this is valuable data. What do we have to compare it against? It's a volumetric measure, like "hits on google.com" or "number of Chrome downloads." Obviously this isn't the complete set of UMAs we need, but it's always nice to have volumetric scales going back to the beginning of time.
On 2012/05/14 15:07:27, Greg Billock wrote: > On 2012/05/10 00:51:26, James Hawkins wrote: > > I'm not sure this is valuable data. What do we have to compare it against? > > It's a volumetric measure, like "hits on google.com" or "number of Chrome > downloads." Obviously this isn't the complete set of UMAs we need, but it's > always nice to have volumetric scales going back to the beginning of time. OK. I'm still suspicious we'll get any value from it, but at least we can point to it as evidence of increased usage (though we won't have any data to say why/how usage increased). LGTM
On 2012/05/14 17:26:49, James Hawkins wrote: > On 2012/05/14 15:07:27, Greg Billock wrote: > > On 2012/05/10 00:51:26, James Hawkins wrote: > > > I'm not sure this is valuable data. What do we have to compare it against? > > > > It's a volumetric measure, like "hits on google.com" or "number of Chrome > > downloads." Obviously this isn't the complete set of UMAs we need, but it's > > always nice to have volumetric scales going back to the beginning of time. > > OK. I'm still suspicious we'll get any value from it, but at least we can point > to it as evidence of increased usage (though we won't have any data to say > why/how usage increased). Yeah, this is definitely just the beginning of the UMAs we'll need. I want to get a basic metric for M20, though, so we can compare aggregate usage as more use cases are enabled. Peter, can I get an owners LGTM? > LGTM
Rubber-stamp LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10347002/14001
Try job failure for 10347002-14001 (retry) (retry) on win_rel for step "compile" (clobber build). It's a second try, previously, step "compile" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10347002/14001
Try job failure for 10347002-14001 (retry) on win_rel for step "compile" (clobber build). It's a second try, previously, step "compile" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/10347002/14001
Try job failure for 10347002-14001 (retry) (retry) on win_rel for step "compile" (clobber build). It's a second try, previously, step "compile" failed. http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu... |