tools/telemetry_tools/find_dependencies_unittest.py - Issue 103433002: [telemetry] Script for finding all Telemetry dependencies.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry_tools/find_dependencies_unittest.py

Issue 103433002: [telemetry] Script for finding all Telemetry dependencies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
	1 #!/usr/bin/env python
	tonyg 2014/01/29 05:10:08 Not necessary, right? We should definitely get th Not necessary, right? We should definitely get these unittests into tools/telemetry/telemetry so that tools/telemetry/run_tests will run them. Otherwise, we'll have to go through a big ordeal to get them running on the bots. dtu 2014/02/13 21:49:35 I kind of think I would like all unit tests to hav Show quoted text On 2014/01/29 05:10:08, tonyg wrote: > Not necessary, right? > > We should definitely get these unittests into tools/telemetry/telemetry so that > tools/telemetry/run_tests will run them. Otherwise, we'll have to go through a > big ordeal to get them running on the bots. I kind of think I would like all unit tests to have a __main__. It's more natural to people who are familiar with Python, but new to Telemetry.
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
	tonyg 2014/01/29 05:10:08 2014 2014 dtu 2014/02/13 21:49:35 Done. Show quoted text On 2014/01/29 05:10:08, tonyg wrote: > 2014 Done.
2 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	4 # found in the LICENSE file.

4	5

	6 import os

5 import unittest	7 import unittest

6	8

7 class TimelineEventTest(unittest.TestCase):	9

	10 class FindDependenciesTest(unittest.TestCase):
	tonyg 2014/01/29 05:10:08 For this test, why not just create a mini, fake te For this test, why not just create a mini, fake telemetry directory with, say one Measurement and PageSet, etc. Then run it against that directory. dtu 2014/02/13 21:49:35 I think I will make unit tests in a followup patch Show quoted text On 2014/01/29 05:10:08, tonyg wrote: > For this test, why not just create a mini, fake telemetry directory with, say > one Measurement and PageSet, etc. Then run it against that directory. I think I will make unit tests in a followup patch. We need to move these files and the bootstrap into tools/telemetry/ before it's unit-testable.
8 pass	11 pass

	12

	13

	14 if __name__ == '__main__':

	15 unittest.main()

OLD	NEW

« tools/telemetry_tools/find_dependencies ('K') | « tools/telemetry_tools/find_dependencies ('k') | tools/telemetry_tools/path_set.py » ('j') | tools/telemetry_tools/path_set.py » ('J')