Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1628)

Unified Diff: chrome/browser/chrome_browser_main.h

Issue 10343007: Retrieving Chrome Variations seed from server and storing in local prefs. Loading seed data from lo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing many nits Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main.cc » ('j') | chrome/browser/chrome_browser_main.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.h
diff --git a/chrome/browser/chrome_browser_main.h b/chrome/browser/chrome_browser_main.h
index fb67705eb5541696ad4446e74ff517b399d924ba..285167e2fd92480ffb04cf47fb8b99623ed6d8e3 100644
--- a/chrome/browser/chrome_browser_main.h
+++ b/chrome/browser/chrome_browser_main.h
@@ -30,6 +30,7 @@ class Profile;
class StartupTimeBomb;
class ShutdownWatcherHelper;
class TranslateManager;
+class VariationsService;
namespace chrome_browser {
// For use by ShowMissingLocaleMessageBox.
@@ -211,11 +212,15 @@ class ChromeBrowserMainParts : public content::BrowserMainParts {
// Members needed across shutdown methods.
bool restart_last_session_;
+ // Initialized in SetupMetricsAndFieldTrials.
+ scoped_ptr<VariationsService> variations_service_;
jwd 2012/05/03 22:27:49 Still need to figure out a better place to put thi
MAD 2012/05/04 20:53:12 I thought we discussed offline that a singleton wo
jwd 2012/05/04 22:11:23 Maybe my comment here is from before the offline d
+
// Tests can set this to true to disable restricting cookie access in the
// network stack, as this can only be done once.
static bool disable_enforcing_cookie_policies_for_tests_;
friend class BrowserMainTest;
+
Alexei Svitkine (slow) 2012/05/04 03:09:53 Nit: Don't add a random empty line. ;)
jwd 2012/05/04 19:33:06 Done.
FRIEND_TEST_ALL_PREFIXES(BrowserMainTest,
WarmConnectionFieldTrial_WarmestSocket);
FRIEND_TEST_ALL_PREFIXES(BrowserMainTest, WarmConnectionFieldTrial_Random);
« no previous file with comments | « no previous file | chrome/browser/chrome_browser_main.cc » ('j') | chrome/browser/chrome_browser_main.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698