Issue 10343002: Make bit-operations return a positive result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10343002: Make bit-operations return a positive result. (Closed)

Created:
8 years, 7 months ago by floitsch

Modified:
8 years, 7 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make bit-operations return a positive result. Fixes issue 2725 (as much as we can fix it). Committed: https://code.google.com/p/dart/source/detail?r=7278

Patch Set 1 #

Patch Set 2 : Rename bit functions. #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : Added test.wq #

Patch Set 5 : Update status file. #

Patch Set 6 : rebase. #

Patch Set 7 : Cache unsigned shift precedences. #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -12 lines)			Patch
M	lib/compiler/implementation/lib/js_helper.dart	View		5 chunks	+8 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1 2 3 4 5 6	5 chunks	+33 lines, -5 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/positive_bit_operations_test.dart	View	1 2 3	1 chunk	+115 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

It would be great with some more tests for this so that once we start ...

8 years, 7 months ago (2012-05-03 07:05:50 UTC) #2

floitsch

8 years, 7 months ago (2012-05-03 11:10:36 UTC) #3

https://chromiumcodereview.appspot.com/10343002/diff/5/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10343002/diff/5/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen.dart:1107: JSBinaryOperatorPrecedence
unsignedShiftPrecedences =
On 2012/05/03 07:05:50, kasperl wrote:
> Could this be cached somewhere? It feels a bit over the top to look it up
every
> single time.

cached as instance field now.

Expand Messages | Collapse Messages