Add gdata content search to file_manager

chrome/browser/resources/file_manager/js/file_copy_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 function FileCopyManager(root) {
   this.copyTasks_ = [];
   this.cancelObservers_ = [];
   this.cancelRequested_ = false;
   this.root_ = root;
 }
@@ skipping 473 matching lines @@
 
   var sourcePath = task.sourceDirEntry.fullPath;
   if (sourceEntry.fullPath.substr(0, sourcePath.length) != sourcePath) {
     // We found an entry in the list that is not relative to the base source
     // path, something is wrong.
     return onError('UNEXPECTED_SOURCE_FILE', sourceEntry.fullPath);
   }
 
   var targetDirEntry = task.targetDirEntry;
   var originalPath = sourceEntry.fullPath.substr(sourcePath.length + 1);
+
+  // If the source entry is GData search result, we should not use the file name
+  // we get from file entry (this will be in format
+  // resource_id.original_file_name). Instead, we should use original_file_name.
+  // Note that if the entry is GData search result, it can only be imediate

[dgozman, 2012/05/03 11:21:47]

typo: imediate

[tbarzic, 2012/05/03 19:16:02]

Done.

+  // child of |task.sourceDirEntry|, so originalPath should be equal to
+  // gdataSearchResult.fileName.
+  var gdataSearchResult =
+      util.getFileAndDisplayNameForGDataSearchResult(sourceEntry.fullPath);
+  if (gdataSearchResult && originalPath == gdataSearchResult.fileName) {
+    if (sourceEntry.isDirectory) {
+      task.registerRename(gdataSearchResult.fileName,

[dgozman, 2012/05/03 11:21:47]

I think, you have to register full paths here instead of just file names.

[tbarzic, 2012/05/03 19:16:02]

Don't we register paths relative to sourceDir. Since dirs for which we have to
this renaming can only be immediate children of the source dir, this should be
ok.

+                          gdataSearchResult.displayName);
+    }
+    originalPath = gdataSearchResult.displayName;

[dgozman, 2012/05/03 11:21:47]

For directory, you do:
1. register rename
2. change fileName to displayName
3. apply rename (from fileName to displayName)

I think, you should just skip step2 (or some cryptic names like
'accidental_resource_id.a.txt' will be renamed twice).

[tbarzic, 2012/05/03 19:16:02]

registered rename paths are automatically appended '/', so we also have to do
step 2 for directories (apply rename won't change the original path because it
doesn't have a trailing /).

I thought about doing this in FileCopyManager.Task.setEntries, but I'd have to
register renames without trailing slash then, which would increase the risk that
we apply rename for a entry whose dir/file name only partially matches the
registered rename. (and, to be honest, this seems fragile enough :/)

+  }
+
   originalPath = task.applyRenames(originalPath);
 
   var targetRelativePrefix = originalPath;
   var targetExt = '';
   var index = targetRelativePrefix.lastIndexOf('.');
   if (index != -1) {
     targetExt = targetRelativePrefix.substr(index);
     targetRelativePrefix = targetRelativePrefix.substr(0, index);
   }
 
@@ skipping 218 matching lines @@
         successCallback(targetEntry, file.size)
       };
       writer.write(file);
     }
 
     targetEntry.createWriter(onWriterCreated, errorCallback);
   }
 
   sourceEntry.file(onSourceFileFound, errorCallback);
 };