Issue 10342005: media::SeekableBuffer should use kNoTimestamp() instead of zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10342005: media::SeekableBuffer should use kNoTimestamp() instead of zero. (Closed)

Created:
8 years, 7 months ago by scherkus (not reviewing)

Modified:
8 years, 7 months ago

Reviewers:
vrk (LEFT CHROMIUM)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

media::SeekableBuffer should use kNoTimestamp() instead of zero. I noticed this while debugging bug 120396 that the reported time remained zero even after appending the initial audio buffer that has a timestamp of zero. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135050

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -14 lines)			Patch
	M	media/base/seekable_buffer.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
	M	media/base/seekable_buffer_unittest.cc	View		2 chunks	+20 lines, -11 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vrk (LEFT CHROMIUM)

8 years, 7 months ago (2012-05-02 22:18:06 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10342005/diff/1/media/base/seekable_bu...
File media/base/seekable_buffer_unittest.cc (right):

https://chromiumcodereview.appspot.com/10342005/diff/1/media/base/seekable_bu...
media/base/seekable_buffer_unittest.cc:331:
EXPECT_EQ(kNoTimestamp().ToInternalValue(),
nit: change to kNoTS?

Expand Messages | Collapse Messages