Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 10337008: ninja windows: fix program path normalization (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja windows: fix program path normalization Fixes currently broken ninja buildbot tests. R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pylib/gyp/msvs_emulation.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
8 years, 7 months ago (2012-05-02 21:42:03 UTC) #1
Nico
lgtm
8 years, 7 months ago (2012-05-02 21:52:47 UTC) #2
scottmg
On 2012/05/02 21:42:03, scottmg wrote: Bah. IDK what the logic here is, but it's not ...
8 years, 7 months ago (2012-05-03 21:12:51 UTC) #3
scottmg
8 years, 7 months ago (2012-05-03 21:24:03 UTC) #4
On 2012/05/03 21:12:51, scottmg wrote:

Even better, 'call' can disappear:

>>> os.path.normpath('call ../../../go.bat')
'..\\go.bat'

Garbage In, Garbage Out, I guess.

Powered by Google App Engine
This is Rietveld 408576698