Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 10335014: Set '-m32' option for host and target platforms (Closed)

Created:
8 years, 7 months ago by yongsheng
Modified:
8 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Set '-m32' option for host and target platforms For different host and target archs, try to check whether their compilers support '-m32' option individually. If yes, then add this option into cflags and ldflags. The exception is that both host and target archs are 'x64'. Committed: https://code.google.com/p/v8/source/detail?r=11597

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M build/common.gypi View 1 4 chunks +23 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jakob Kummerow
LGTM if comments are addressed. Thanks for contributing! http://codereview.chromium.org/10335014/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10335014/diff/1/build/common.gypi#newcode281 build/common.gypi:281: ['v8_target_arch!="x64"', ...
8 years, 7 months ago (2012-05-15 14:05:34 UTC) #1
yongsheng
http://codereview.chromium.org/10335014/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10335014/diff/1/build/common.gypi#newcode281 build/common.gypi:281: ['v8_target_arch!="x64"', { On 2012/05/15 14:05:34, Jakob wrote: > The ...
8 years, 7 months ago (2012-05-15 14:20:49 UTC) #2
yongsheng
http://codereview.chromium.org/10335014/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10335014/diff/1/build/common.gypi#newcode281 build/common.gypi:281: ['v8_target_arch!="x64"', { On 2012/05/15 14:05:34, Jakob wrote: > The ...
8 years, 7 months ago (2012-05-15 14:36:03 UTC) #3
yongsheng
I upload the new patch according to your comments. Please have a check. Anyone else ...
8 years, 7 months ago (2012-05-15 14:43:42 UTC) #4
Jakob Kummerow
Patch set 2 LGTM. I'll be back in the office on Friday, at which point ...
8 years, 7 months ago (2012-05-15 16:21:54 UTC) #5
yongsheng
On 2012/05/15 16:21:54, Jakob wrote: > Patch set 2 LGTM. I'll be back in the ...
8 years, 7 months ago (2012-05-16 00:30:58 UTC) #6
yongsheng
On 2012/05/15 16:21:54, Jakob wrote: > Patch set 2 LGTM. I'll be back in the ...
8 years, 7 months ago (2012-05-21 05:56:34 UTC) #7
Jakob Kummerow
On 2012/05/21 05:56:34, yongsheng.zhu wrote: > If any problem, would you please let me know? ...
8 years, 7 months ago (2012-05-21 09:02:33 UTC) #8
yongsheng
8 years, 7 months ago (2012-05-21 09:03:51 UTC) #9
On 2012/05/21 09:02:33, Jakob wrote:
> On 2012/05/21 05:56:34, yongsheng.zhu wrote:
> > If any problem, would you please let me know? Thanks
> 
> Landed as r11597, with a small fix for the "android" target added to the
> Makefile.
> 
> It also doesn't work for Mac; I have a separate fix for that coming up.
thanks!

Powered by Google App Engine
This is Rietveld 408576698