Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 10335002: fix vm test configuration to specify vm/cc (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 3f698a6bf7ebf90a8294ae7548606c309337221f..d7706f3760a5eee52d43d30e62a4fe1026bf2f0c 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -100,6 +100,7 @@ class CCTestListerIsolate extends Isolate {
class CCTestSuite implements TestSuite {
Map configuration;
final String suiteName;
+ final String testPrefix;
String runnerPath;
final String dartDir;
List<String> statusFilePaths;
@@ -111,7 +112,8 @@ class CCTestSuite implements TestSuite {
CCTestSuite(Map this.configuration,
String this.suiteName,
String runnerName,
- List<String> this.statusFilePaths)
+ List<String> this.statusFilePaths,
+ [this.testPrefix = ''])
: dartDir = TestUtils.dartDir() {
runnerPath = TestUtils.buildDir(configuration) + '/' + runnerName;
}
@@ -124,10 +126,11 @@ class CCTestSuite implements TestSuite {
// Only run the tests that match the pattern. Use the name
// "suiteName/testName" for cc tests.
RegExp pattern = configuration['selectors'][suiteName];
- String constructedName = '$suiteName/$testName';
+ String constructedName = '$suiteName/$testPrefix$testName';
if (!pattern.hasMatch(constructedName)) return;
- var expectations = testExpectations.expectations(testName);
+ var expectations = testExpectations.expectations(
+ '$testPrefix$testName');
if (configuration["report"]) {
SummaryReport.add(expectations);
@@ -140,7 +143,7 @@ class CCTestSuite implements TestSuite {
var args = [testName];
args.addAll(TestUtils.standardOptions(configuration));
- doTest(new TestCase('$suiteName/$testName',
+ doTest(new TestCase(constructedName,
[new Command(runnerPath, args)],
configuration,
completeHandler,
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698