Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 10332313: Update upload.py @ f218528d3469 (Closed)

Created:
8 years, 7 months ago by Roger Tawa OOO till Jul 10th
Modified:
8 years, 7 months ago
Reviewers:
maruel, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Update upload.py @ f218528d3469 BUG=None TEST=gcl upload now uploads any type of binary file, not just images. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M third_party/upload.py View 5 chunks +18 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Roger Tawa OOO till Jul 10th
8 years, 7 months ago (2012-05-23 13:31:46 UTC) #1
M-A Ruel
That's the version in branch default or chromium?
8 years, 7 months ago (2012-05-23 13:36:16 UTC) #2
Roger Tawa OOO till Jul 10th
Salut MA, That is the version of the merge in the chromium branch. http://code.google.com/p/rietveld/source/detail?r=f218528d3469a586d67577d472566c95d2004e4e&name=chromium
8 years, 7 months ago (2012-05-23 13:43:22 UTC) #3
M-A Ruel
lgtm
8 years, 7 months ago (2012-05-23 13:43:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/10332313/1
8 years, 7 months ago (2012-05-23 13:44:23 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 13:51:21 UTC) #6
Change committed as 138469

Powered by Google App Engine
This is Rietveld 408576698