Issue 10332303: [Chromoting] Simple script to print out installed mac version info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332303: [Chromoting] Simple script to print out installed mac version info. (Closed)

Created:
8 years, 7 months ago by garykac

Modified:
8 years, 7 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Chromoting] Simple script to print out installed mac version info. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138401

Patch Set 1 #

Total comments: 1

Patch Set 2 : +x and fix quotes #

Patch Set 3 : Add copyright header #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	A	remoting/tools/get_mac_crd_version.sh	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jamie

8 years, 7 months ago (2012-05-22 23:44:08 UTC) #2

LGTM. Can you make it executable if it isn't already?

http://codereview.chromium.org/10332303/diff/1/remoting/tools/get_mac_crd_ver...
File remoting/tools/get_mac_crd_version.sh (right):

http://codereview.chromium.org/10332303/diff/1/remoting/tools/get_mac_crd_ver...
remoting/tools/get_mac_crd_version.sh:16: echo "${name}" version = "${1}"
Nit: quotes around the whole string would be more readable.

Expand Messages | Collapse Messages