Map the client certificate related SSL alerts to

Map the certificate related SSL alerts to ERR_BAD_SSL_CLIENT_AUTH_CERT
on the client side.

Move MapNSSHandshakeError to ssl_client_socket_nss.cc (and rename it
MapNSSClientHandshakeError) because it is specific to the client side.

R=rsleevi@chromium.org
BUG=129209
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140897

[wtc, 2012-05-22 19:05:00]

The NSS code that maps these client certificate related alerts
to the NSS error codes in this CL is at

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/nss/lib/ssl/ssl3...

[Ryan Sleevi, 2012-05-22 19:14:11]

https://chromiumcodereview.appspot.com/10332300/diff/1/net/socket/nss_ssl_uti...
File net/socket/nss_ssl_util.cc (right):

https://chromiumcodereview.appspot.com/10332300/diff/1/net/socket/nss_ssl_uti...
net/socket/nss_ssl_util.cc:175: return ERR_BAD_SSL_CLIENT_AUTH_CERT;
The interpretation of these are dependent upon whether we're in client mode or
server mode.

Otherwise, this mapping LGTM, as it matches SSLClientSocketMac.

[wtc, 2012-05-29 23:41:00]

rsleevi: please review patch set 2.

Thank you for your comment. You are right that the interpretation
of these certificate-related alerts depends on whether we're
in the server mode or client mode.

https://chromiumcodereview.appspot.com/10332300/diff/3001/net/socket/ssl_clie...
File net/socket/ssl_client_socket_nss.cc (right):

https://chromiumcodereview.appspot.com/10332300/diff/3001/net/socket/ssl_clie...
net/socket/ssl_client_socket_nss.cc:1593: int error =
MapNSSError(PORT_GetError());

Get the NSS error code first, otherwise it could be overwritten
by the CERT_DestroyCertificate call.

[Ryan Sleevi, 2012-05-29 23:44:34]

lgtm

[commit-bot: I haz the power, 2012-06-06 22:20:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/10332300/13001

[commit-bot: I haz the power, 2012-06-07 00:18:45]

Change committed as 140897