Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: lib/compiler/implementation/lib/js_helper.dart

Issue 10332291: Negative numbers should not be >>> shifted. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix test. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/positive_bit_operations_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/js_helper.dart
diff --git a/lib/compiler/implementation/lib/js_helper.dart b/lib/compiler/implementation/lib/js_helper.dart
index c46f2f42b49b0d96f54c624576d92c45da2c46ba..e8e0497ba1051b052f4a149bf011b1af0098c30d 100644
--- a/lib/compiler/implementation/lib/js_helper.dart
+++ b/lib/compiler/implementation/lib/js_helper.dart
@@ -178,7 +178,8 @@ shr(var a, var b) {
// JavaScript only looks at the last 5 bits of the shift-amount. Shifting
// by 33 is hence equivalent to a shift by 1.
if (b > 31) return 0;
- return JS('num', @'# >>> #', a, b);
+ if (a >= 0) return JS('num', @'# >>> #', a, b);
+ return JS('num', @'(# >> #) >>> 0', a, b);
ngeoffray 2012/05/22 15:46:31 Please add a comment on what this entails.
floitsch 2012/05/22 21:07:37 Done.
}
return UNINTERCEPTED(a >> b);
}
« no previous file with comments | « no previous file | tests/language/positive_bit_operations_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698