Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 10332289: Add RemoteInspectorClient.EvaluateJavascript to run javascript over the remote inspector protocl (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Add RemoteInspectorClient.EvaluateJavascript to run javascript over the remote inspector protocl BUG=none TEST=none NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138446

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -12 lines) Patch
M chrome/test/pyautolib/remote_inspector_client.py View 9 chunks +51 lines, -12 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
please review
8 years, 7 months ago (2012-05-22 14:52:07 UTC) #1
marja
lgtm
8 years, 7 months ago (2012-05-22 14:54:38 UTC) #2
Nirnimesh
Is there a reason you chose to re-implement javascript execution via remote inspector while an ...
8 years, 7 months ago (2012-05-22 16:25:17 UTC) #3
jochen (gone - plz use gerrit)
On 2012/05/22 16:25:17, Nirnimesh wrote: > Is there a reason you chose to re-implement javascript ...
8 years, 7 months ago (2012-05-22 16:42:42 UTC) #4
dennis_jeffrey
Quick question - the rest looks good. https://chromiumcodereview.appspot.com/10332289/diff/1/chrome/test/pyautolib/remote_inspector_client.py File chrome/test/pyautolib/remote_inspector_client.py (right): https://chromiumcodereview.appspot.com/10332289/diff/1/chrome/test/pyautolib/remote_inspector_client.py#newcode808 chrome/test/pyautolib/remote_inspector_client.py:808: A dictionary ...
8 years, 7 months ago (2012-05-22 17:14:05 UTC) #5
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/10332289/diff/1/chrome/test/pyautolib/remote_inspector_client.py File chrome/test/pyautolib/remote_inspector_client.py (right): https://chromiumcodereview.appspot.com/10332289/diff/1/chrome/test/pyautolib/remote_inspector_client.py#newcode808 chrome/test/pyautolib/remote_inspector_client.py:808: A dictionary representing the result. On 2012/05/22 17:14:05, dennis_jeffrey ...
8 years, 7 months ago (2012-05-23 08:20:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10332289/1
8 years, 7 months ago (2012-05-23 08:21:17 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 08:21:28 UTC) #8
Change committed as 138446

Powered by Google App Engine
This is Rietveld 408576698