Fix NTP issue because of -webkit-flexbox -> -webkit-flex rename

Fix NTP issue because of -webkit-flexbox -> -webkit-flex rename.

R=estade@chromium.org
BUG=None (yet)
TEST=The vertical separator between recently close and webstore footer link works.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138113

[Evan Stade, 2012-05-21 18:25:12]

lgtm

-- Evan Stade


On Mon, May 21, 2012 at 11:24 AM, <dbeam@chromium.org> wrote:

> Reviewers: Evan Stade,
>
> Description:
> Fix NTP issue because of -webkit-flexbox -> -webkit-flex rename
>
> R=estade@chromium.org
> BUG=None (yet)
> TEST=The vertical separator between recently close and webstore footer link
> works.
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10332274/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/resources/ntp4/**new_tab.css
>
>
> Index: chrome/browser/resources/ntp4/**new_tab.css
> diff --git a/chrome/browser/resources/**ntp4/new_tab.css
> b/chrome/browser/resources/**ntp4/new_tab.css
> index 9d6219763a5fd2eedc81a8504b0315**7e54a1ce02..**
> 5cbfa672cd0d77c8e91271dbc6b9fa**95322a8700 100644
> --- a/chrome/browser/resources/**ntp4/new_tab.css
> +++ b/chrome/browser/resources/**ntp4/new_tab.css
> @@ -402,8 +402,8 @@ html[dir='rtl'] #chrome-web-store-title {
>
>  #footer .menu-container {
>   -webkit-flex-align: center;
> -  /* Put menus in a flexbox so the order can easily be swapped. */
> -  display: -webkit-flexbox;
> +  /* Put menus in a flexible box so the order can easily be swapped. */
> +  display: -webkit-flex;
>   height: 100%;
>   margin: 0;
>  }
>
>
>

[tony, 2012-05-21 23:09:34]

FWIW, using flex-order instead of modifying the DOM to change the order of
elements may cause problems if you try to select text (doesn't seem to apply
here) or if you try to tab through the elements.  The tab order follows the
document order, which may not match the visual order.

[Evan Stade, 2012-05-22 00:57:39]

On 2012/05/21 23:09:34, tony wrote:
> FWIW, using flex-order instead of modifying the DOM to change the order of
> elements may cause problems if you try to select text (doesn't seem to apply
> here) or if you try to tab through the elements.  The tab order follows the
> document order, which may not match the visual order.

the tab order is only affected when one of the two elements is not visible, so
you can't tab to it anyway. So we're safe in this case.

I still have the same opinion that I expressed at the bottom of
https://bugs.webkit.org/show_bug.cgi?id=62664 although it appears that I was
feeling annoyed at the time I wrote it and perhaps discussed the issue a little
too passionately.