Change modification date to include time and 'today' and 'yesterday' for appropriate dates.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * FileManager constructor.
  *
  * FileManager objects encapsulate the functionality of the file selector
  * dialogs, as well as the full screen file manager application (though the
  * latter is not yet implemented).
@@ skipping 29 matching lines @@
   this.dialogType_ = this.params_.type || FileManager.DialogType.FULL_PAGE;
 
   metrics.recordEnum('Create', this.dialogType_,
       [FileManager.DialogType.SELECT_FOLDER,
       FileManager.DialogType.SELECT_SAVEAS_FILE,
       FileManager.DialogType.SELECT_OPEN_FILE,
       FileManager.DialogType.SELECT_OPEN_MULTI_FILE,
       FileManager.DialogType.FULL_PAGE]);
 
   // TODO(dgozman): This will be changed to LocaleInfo.
   this.locale_ = new v8Locale(navigator.language);

[dgozman, 2012/05/21 15:45:41]

Should this be changed as well?

[Oleg Eterevsky, 2012/05/21 15:53:55]

I'd rather do it once v8Intl is in the stable version of Chrome. Otherwise,
we'll have to write mocks for all i18n features.

 
   this.initFileSystem_();
   this.initDom_();
   this.initDialogType_();
   this.dialogDom_.style.opacity = '1';
 }
 
 /**
  * Maximum delay in milliseconds for updating thumbnails in the bottom panel
  * to mitigate flickering. If images load faster then the delay they replace
@@ skipping 53 matching lines @@
   var IMAGE_HOVER_PREVIEW_SIZE = 200;
 
   /**
    * The minimum about of time to display the butter bar for, in ms.
    * Justification is 1000ms for minimum display time plus 300ms for transition
    * duration.
    */
   var MINIMUM_BUTTER_DISPLAY_TIME_MS = 1300;
 
   /**
+   * Number of milliseconds in a day.
+   */
+  var MILLISECONDS_IN_DAY = 24 * 60 * 60 * 1000;
+
+  /**
    * Item for the Grid View.
    * @constructor
    */
   function GridItem(fileManager, entry) {
     var li = fileManager.document_.createElement('li');
     GridItem.decorate(li, fileManager, entry);
     return li;
   }
 
   GridItem.prototype = {
@@ skipping 187 matching lines @@
 
   /**
    * Continue initializing the file manager after resolving roots.
    */
   FileManager.prototype.init_ = function() {
     metrics.startInterval('Load.DOM');
     this.initCommands_();
 
     this.metadataCache_ = MetadataCache.createFull();
 
-    this.shortDateFormatter_ =
-      this.locale_.createDateTimeFormat({'dateType': 'medium'});
+    this.dateFormatter_ = v8Intl.DateTimeFormat(
+        undefined,

[dgozman, 2012/05/21 15:45:41]

Comment what undefined means.

[Oleg Eterevsky, 2012/05/21 15:53:55]

Done.

+        {year: 'numeric', month: 'short', day: 'numeric',
+         hour: 'numeric', minute: 'numeric'});
+    this.timeFormatter_ = v8Intl.DateTimeFormat(
+        undefined, {hour: 'numeric', minute: 'numeric'});
 
     this.collator_ = this.locale_.createCollator({
       'numeric': true, 'ignoreCase': true, 'ignoreAccents': true});
 
     // Optional list of file types.
     this.fileTypes_ = this.params_.typeList;
 
     this.showCheckboxes_ =
         (this.dialogType_ == FileManager.DialogType.FULL_PAGE ||
          this.dialogType_ == FileManager.DialogType.SELECT_OPEN_MULTI_FILE);
@@ skipping 321 matching lines @@
     this.initGrid_();
     this.initRootsList_();
 
     var listType = FileManager.ListType.DETAIL;
     if (FileManager.DialogType.isModal(this.dialogType_))
       listType = window.localStorage['listType-' + this.dialogType_] ||
           FileManager.ListType.DETAIL;
     this.setListType(listType);
 
     this.textSearchState_ = {text: '', date: new Date()};
+
+    // Update metadata once per minute to change 'Today' and 'Yesterday'

[dgozman, 2012/05/21 15:45:41]

Wrong comment?

[Oleg Eterevsky, 2012/05/21 15:53:55]

Done.

+    // modification time on
+    var today = new Date();
+    today.setHours(0);
+    today.setMinutes(0);
+    today.setSeconds(0);
+    today.setMilliseconds(0);
+    setTimeout(this.dailyUpdateModificationTime_.bind(this),
+               today.getTime() + MILLISECONDS_IN_DAY - Date.now() + 1000);
   };
 
   FileManager.prototype.initRootsList_ = function() {
     this.rootsList_ = this.dialogDom_.querySelector('#roots-list');
     cr.ui.List.decorate(this.rootsList_);
     this.rootsList_.startBatchUpdates();
 
     var self = this;
     this.rootsList_.itemConstructor = function(entry) {
       return self.renderRoot_(entry);
@@ skipping 1271 matching lines @@
     div.className = 'date';
 
     this.updateDate_(div,
         this.metadataCache_.getCached(entry, 'filesystem'));
     return div;
   };
 
   FileManager.prototype.updateDate_ = function(div, filesystemProps) {
     if (!filesystemProps) {
       div.textContent = '...';
+      return;
+    }
+
+    var modTime = filesystemProps.modificationTime;
+    var today = new Date();
+    today.setHours(0);
+    today.setMinutes(0);
+    today.setSeconds(0);
+    today.setMilliseconds(0);
+
+    if (modTime >= today &&
+        modTime < today.getTime() + MILLISECONDS_IN_DAY) {
+      div.textContent = strf('TIME_TODAY', this.timeFormatter_.format(modTime));
+    } else if (modTime >= today - MILLISECONDS_IN_DAY && modTime < today) {
+      div.textContent = strf('TIME_YESTERDAY',
+                             this.timeFormatter_.format(modTime));
     } else {
       div.textContent =
-          this.shortDateFormatter_.format(filesystemProps.modificationTime);
+          this.dateFormatter_.format(filesystemProps.modificationTime);
     }
   };
 
   FileManager.prototype.renderOffline_ = function(entry, columnId, table) {
     var doc = this.document_;
     var div = doc.createElement('div');
     div.className = 'offline';
 
     if (entry.isDirectory)
       return div;
@@ skipping 27 matching lines @@
     // observer registered to update the UI.
 
     this.metadataCache_.clear(entries, 'filesystem');
     this.metadataCache_.get(entries, 'filesystem', null);
     if (this.isOnGData()) {
       this.metadataCache_.clear(entries, 'gdata');
       this.metadataCache_.get(entries, 'gdata', null);
     }
   };
 
+  FileManager.prototype.dailyUpdateModificationTime_ = function() {
+    var fileList = this.directoryModel_.getFileList();
+    var urls = [];
+    for (var i = 0; i < fileList.length; i++) {
+      urls.push(fileList.item(i).toURL());
+    }
+    this.metadataCache_.get(
+        urls, 'filesystem',

[dgozman, 2012/05/21 15:45:41]

Passing entries instead of urls will greatly speed up the process.

[Oleg Eterevsky, 2012/05/21 15:53:55]

Done.

+        this.updateMetadataInUI_.bind(this, 'filesystem', urls));
+
+    setTimeout(this.dailyUpdateModificationTime_.bind(this),
+               MILLISECONDS_IN_DAY);
+  };
+
   FileManager.prototype.updateMetadataInUI_ = function(
       type, urls, properties) {
     if (this.listType_ != FileManager.ListType.DETAIL) return;
 
     var items = {};
     var entries = {};
     var dm = this.directoryModel_.getFileList();
     for (var index = 0; index < dm.length; index++) {
       var listItem = this.currentList_.getListItemByIndex(index);
       if (!listItem) continue;
@@ skipping 2630 matching lines @@
 
     function closeBanner() {
       self.cleanupGDataWelcome_();
       // Stop showing the welcome banner.
       localStorage[WELCOME_HEADER_COUNTER_KEY] = WELCOME_HEADER_COUNTER_LIMIT;
     }
 
     return maybeShowBanner;
   };
 })();