Change modification date to include time and 'today' and 'yesterday' for appropriate dates.

Change modification date to include time and 'today' and 'yesterday' for appropriate dates.

BUG=127072
TEST=The date column in file manager includes time and for files, modified in the last two days it has 'Today' and 'Yesterday' instead of date.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138237

[dgozman, 2012-05-21 15:45:41]

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/app/generate...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/app/generate...
chrome/app/generated_resources.grd:11085: +        Yesterday <ph
name="YESTERDAY_DATTIME">$1<ex>4:48 PM</ex></ph>
typo: DATTIME

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:50: this.locale_ = new
v8Locale(navigator.language);
Should this be changed as well?

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:337: undefined,
Comment what undefined means.

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:684: // Update metadata
once per minute to change 'Today' and 'Yesterday'
Wrong comment?

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:2057: urls,
'filesystem',
Passing entries instead of urls will greatly speed up the process.

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/mock_chrome.js (right):

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/mock_chrome.js:741: * @constructor
missing @param

[Oleg Eterevsky, 2012-05-21 15:53:55]

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/app/generate...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/app/generate...
chrome/app/generated_resources.grd:11085: +        Yesterday <ph
name="YESTERDAY_DATTIME">$1<ex>4:48 PM</ex></ph>
On 2012/05/21 15:45:41, dgozman wrote:
> typo: DATTIME

Done.

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:50: this.locale_ = new
v8Locale(navigator.language);
On 2012/05/21 15:45:41, dgozman wrote:
> Should this be changed as well?

I'd rather do it once v8Intl is in the stable version of Chrome. Otherwise,
we'll have to write mocks for all i18n features.

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:337: undefined,
On 2012/05/21 15:45:41, dgozman wrote:
> Comment what undefined means.

Done.

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:684: // Update metadata
once per minute to change 'Today' and 'Yesterday'
On 2012/05/21 15:45:41, dgozman wrote:
> Wrong comment?

Done.

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:2057: urls,
'filesystem',
On 2012/05/21 15:45:41, dgozman wrote:
> Passing entries instead of urls will greatly speed up the process.

Done.

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/mock_chrome.js (right):

https://chromiumcodereview.appspot.com/10332272/diff/2002/chrome/browser/reso...
chrome/browser/resources/file_manager/js/mock_chrome.js:741: * @constructor
On 2012/05/21 15:45:41, dgozman wrote:
> missing @param

Done.

[rginda, 2012-05-21 15:56:07]

https://chromiumcodereview.appspot.com/10332272/diff/8003/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10332272/diff/8003/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:337: undefined /*
default locale */,
Please don't pass around undefined like this.   Use null instead.

'undefined' is a variable that can be assigned to.  To reliably specify
undefined you need something like (void 0).  Also, undefined is to easy to pass
"on accident" (leaving out a parameter, for example), whereas null can only be
passed on purpose.

[dgozman, 2012-05-21 16:02:33]

LGTM after changing undefined to null, as Robert suggests

[Oleg Eterevsky, 2012-05-22 05:52:43]

https://chromiumcodereview.appspot.com/10332272/diff/8003/chrome/browser/reso...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10332272/diff/8003/chrome/browser/reso...
chrome/browser/resources/file_manager/js/file_manager.js:337: undefined /*
default locale */,
On 2012/05/21 15:56:08, rginda wrote:
> Please don't pass around undefined like this.   Use null instead.
> 
> 'undefined' is a variable that can be assigned to.  To reliably specify
> undefined you need something like (void 0).  Also, undefined is to easy to
pass
> "on accident" (leaving out a parameter, for example), whereas null can only be
> passed on purpose.

Changed to {}. null doesn't work here.