Issue 10332267: Revert 138055 - gdata: Add requestDirectoryRefresh to file_browser_private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332267: Revert 138055 - gdata: Add requestDirectoryRefresh to file_browser_private. (Closed)

Created:
8 years, 7 months ago by satorux1

Modified:
8 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 138055 - gdata: Add requestDirectoryRefresh to file_browser_private. Broke unit_tests on Debug build. The new API is used to fetch the metadata of files in a particular directory. More specifically, the new API is used to fix the stale thumbnail URL issue. BUG=127697 TEST=added a unit test. Review URL: https://chromiumcodereview.appspot.com/10386226 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138056

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -188 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
MM	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	3 chunks	+0 lines, -22 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	1 chunk	+0 lines, -104 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_files.cc	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_file_system.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_registry.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/file_browser_private.json	View	1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages