Issue 10332264: ui/base/models: Remove unnecessary virtuals from ListModel functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332264: ui/base/models: Remove unnecessary virtuals from ListModel functions. (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ui/base/models: Remove unnecessary virtuals from ListModel functions. ListModel is intended to be used as composition not inheritance, so it's unlikely these functions will be needed to be overridden, and they aren't until now, so let's not make them virtual for now. R=xiyuan@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138062

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	ui/base/models/list_model.h	View		2 chunks	+11 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm