Revert my last change.

runtime/lib/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 221 matching lines @@
     const String& error_str = String::Handle(
         String::New("Error starting Isolate, class not loaded : "));
     const Error& error = Error::Handle(LanguageError::New(error_str));
     Isolate::Current()->object_store()->set_sticky_error(error);
     return false;
   }
   return true;  // No errors.
 }
 
 
-static char* GetRootScriptUri(Isolate* isolate) {
-  const Library& library =
-      Library::Handle(isolate->object_store()->root_library());
-  ASSERT(!library.IsNull());
-  const String& script_name = String::Handle(library.url());
-  return isolate->current_zone()->MakeCopyOfString(script_name.ToCString());
-}
+static char* BuildIsolateName(const char* script_name,
+                              const char* class_name,
+                              const char* func_name) {
+  // Skip past any slashes in the script name.
+  const char* last_slash = strrchr(script_name, '/');
+  if (last_slash != NULL) {
+    script_name = last_slash + 1;
+  }
 
-
-static char* BuildMainName(const char* class_name) {
-  intptr_t len = OS::SNPrint(NULL, 0, "%s.main", class_name) + 1;
-  char* chars = reinterpret_cast<char*>(
-      Isolate::Current()->current_zone()->Allocate(len));
-  OS::SNPrint(chars, len, "%s.main", class_name);
+  char* chars = NULL;
+  if (class_name && class_name[0] != '\0') {
+    const char* kFormat = "%s/%s.%s";
+    intptr_t len = OS::SNPrint(NULL, 0, kFormat, script_name, class_name,
+                               func_name) + 1;
+    chars = reinterpret_cast<char*>(
+        Isolate::Current()->current_zone()->Allocate(len));
+    OS::SNPrint(chars, len, kFormat, script_name, class_name, func_name);
+  } else {
+    const char* kFormat = "%s/%s";
+    intptr_t len = OS::SNPrint(NULL, 0, kFormat, script_name, func_name) + 1;
+    chars = reinterpret_cast<char*>(
+        Isolate::Current()->current_zone()->Allocate(len));
+    OS::SNPrint(chars, len, kFormat, script_name, func_name);
+  }
   return chars;
 }
 
 
 DEFINE_NATIVE_ENTRY(IsolateNatives_start, 2) {
   Isolate* preserved_isolate = Isolate::Current();
   GET_NATIVE_ARGUMENT(Instance, runnable, arguments->At(0));
   // arguments->At(1) unused.
   const Class& runnable_class = Class::Handle(runnable.clazz());
   const char* class_name = String::Handle(runnable_class.Name()).ToCString();
   const Library& library = Library::Handle(runnable_class.library());
   ASSERT(!library.IsNull());
   const char* library_url = String::Handle(library.url()).ToCString();
   intptr_t port_id = 0;
   LongJump jump;
   bool init_successful = true;
   Isolate* spawned_isolate = NULL;
   void* callback_data = preserved_isolate->init_callback_data();
   char* error = NULL;
   Dart_IsolateCreateCallback callback = Isolate::CreateCallback();
-  const char* root_script_uri = GetRootScriptUri(preserved_isolate);
-  const char* main = BuildMainName(class_name);
+  const char* isolate_name = BuildIsolateName(library_url, class_name, "main");
   if (callback == NULL) {
     error = strdup("Null callback specified for isolate creation\n");
-  } else if (callback(root_script_uri, main, callback_data, &error)) {
+  } else if (callback(isolate_name, callback_data, &error)) {
     spawned_isolate = Isolate::Current();
     ASSERT(spawned_isolate != NULL);
     // Check arguments to see if the specified library and classes are
     // loaded, this check will throw an exception if they are not loaded.
     if (init_successful && CheckArguments(library_url, class_name)) {
       port_id = spawned_isolate->main_port();
       spawned_isolate->set_spawn_data(
           reinterpret_cast<uword>(
               new IsolateStartData(strdup(library_url),
                                    strdup(class_name),
@@ skipping 79 matching lines @@
 }
 
 
 static void ThrowIsolateSpawnException(const String& message) {
   GrowableArray<const Object*> args(1);
   args.Add(&message);
   Exceptions::ThrowByType(Exceptions::kIsolateSpawn, args);
 }
 
 
-static bool CanonicalizeUri(Isolate* isolate,
-                            const Library& library,
-                            const String& uri,
-                            char** canonical_uri,
-                            char** error) {
-  Zone* zone = isolate->current_zone();
-  Dart_LibraryTagHandler handler = isolate->library_tag_handler();
-  if (handler == NULL) {
-    *error = zone->PrintToString(
-        "Unable to canonicalize uri '%s': no library tag handler found.",
-        uri.ToCString());
-    return false;
-  }
-  Dart_Handle result = handler(kCanonicalizeUrl,
-                               Api::NewHandle(isolate, library.raw()),
-                               Api::NewHandle(isolate, uri.raw()));
-  const Object& obj = Object::Handle(Api::UnwrapHandle(result));
-  if (obj.IsError()) {
-    Error& error_obj = Error::Handle();
-    error_obj ^= obj.raw();
-    *error = zone->PrintToString("Unable to canonicalize uri '%s': %s",
-                                 uri.ToCString(), error_obj.ToErrorCString());
-    return false;
-  } else if (obj.IsString()) {
-    String& string_obj = String::Handle();
-    string_obj ^= obj.raw();
-    *canonical_uri = zone->MakeCopyOfString(string_obj.ToCString());
-    return true;
-  } else {
-    *error = zone->PrintToString("Unable to canonicalize uri '%s': "
-                                 "library tag handler returned wrong type",
-                                 uri.ToCString());
-    return false;
-  }
-}
-
-
 class SpawnState {
  public:
   explicit SpawnState(const Function& func)
       : isolate_(NULL),
-        script_url_(NULL),
         library_url_(NULL),
         function_name_(NULL) {
-    script_url_ = strdup(GetRootScriptUri(Isolate::Current()));
     const Class& cls = Class::Handle(func.owner());
     ASSERT(cls.IsTopLevel());
     const Library& lib = Library::Handle(cls.library());
     const String& lib_url = String::Handle(lib.url());
     library_url_ = strdup(lib_url.ToCString());
 
     const String& func_name = String::Handle(func.name());
     function_name_ = strdup(func_name.ToCString());
   }
 
-  explicit SpawnState(const char* script_url)
-      : isolate_(NULL),
-        library_url_(NULL),
-        function_name_(NULL) {
-    script_url_ = strdup(script_url);
-    library_url_ = NULL;
-    function_name_ = strdup("main");
-  }
-
   ~SpawnState() {
-    free(script_url_);
     free(library_url_);
     free(function_name_);
   }
 
   Isolate* isolate() const { return isolate_; }
   void set_isolate(Isolate* value) { isolate_ = value; }
-  char* script_url() const { return script_url_; }
   char* library_url() const { return library_url_; }
   char* function_name() const { return function_name_; }
 
-  RawObject* ResolveFunction() {
-    // Resolve the library.
-    Library& lib = Library::Handle();
-    if (library_url()) {
-      const String& lib_url = String::Handle(String::New(library_url()));
-      lib = Library::LookupLibrary(lib_url);
-      if (lib.IsNull() || lib.IsError()) {
-        const String& msg = String::Handle(String::NewFormatted(
-            "Unable to find library '%s'.", library_url()));
-        return LanguageError::New(msg);
-      }
-    } else {
-      lib = isolate()->object_store()->root_library();
+  RawFunction* ResolveFunction() {
+    const String& lib_url =
+        String::Handle(String::NewSymbol(library_url()));
+    const String& func_name =
+        String::Handle(String::NewSymbol(function_name()));
+
+    const Library& lib = Library::Handle(Library::LookupLibrary(lib_url));
+    if (lib.IsNull() || lib.IsError()) {
+      return Function::null();
     }
-    ASSERT(!lib.IsNull());
-
-    // Resolve the function.
-    const String& func_name =
-        String::Handle(String::New(function_name()));
-    const Function& func = Function::Handle(lib.LookupLocalFunction(func_name));
-    if (func.IsNull()) {
-      const String& msg = String::Handle(String::NewFormatted(
-          "Unable to resolve function '%s' in library '%s'.",
-          function_name(), (library_url() ? library_url() : script_url())));
-      return LanguageError::New(msg);
-    }
-    return func.raw();
+    return lib.LookupLocalFunction(func_name);
   }
 
   void Cleanup() {
     SwitchIsolateScope switch_scope(isolate());
     Dart::ShutdownIsolate();
   }
 
  private:
   Isolate* isolate_;
-  char* script_url_;
   char* library_url_;
   char* function_name_;
 };
 
 
 static bool CreateIsolate(SpawnState* state, char** error) {
   Isolate* parent_isolate = Isolate::Current();
 
   Dart_IsolateCreateCallback callback = Isolate::CreateCallback();
-  ASSERT(callback != NULL);
+  ASSERT(callback);
+  const char* isolate_name = BuildIsolateName(state->library_url(),
+                                              "",
+                                              state->function_name());
   void* init_data = parent_isolate->init_callback_data();
-  bool retval = (callback)(state->script_url(),
-                           state->function_name(),
-                           init_data,
-                           error);
-  if (!retval) {
-    Isolate::SetCurrent(parent_isolate);
-    return false;
-  }
+  bool retval = (callback)(isolate_name, init_data, error);
+  if (retval) {
+    Isolate* child_isolate = Isolate::Current();
+    ASSERT(child_isolate);
+    state->set_isolate(child_isolate);
 
-  Isolate* child_isolate = Isolate::Current();
-  ASSERT(child_isolate);
-  state->set_isolate(child_isolate);
-
-  // Attempt to resolve the entry function now, so that we fail fast
-  // in the case that the function cannot be resolved.
-  //
-  // TODO(turnidge): Revisit this once we have an isolate death api.
-  bool resolve_error = false;
-  {
-    Zone zone(child_isolate);
-    HandleScope handle_scope(child_isolate);
-    const Object& result = Object::Handle(state->ResolveFunction());
-    if (result.IsError()) {
-      Error& errobj = Error::Handle();
-      errobj ^= result.raw();
-      *error = strdup(errobj.ToErrorCString());
-      resolve_error = true;
+    // Attempt to resolve the entry function now, so that we fail fast
+    // in the case that the embedder's isolate create callback is
+    // violating its contract.
+    //
+    // TODO(turnidge): Revisit this once we have an isolate death api.
+    {
+      Zone zone(child_isolate);
+      HandleScope handle_scope(child_isolate);
+      const Function& func = Function::Handle(state->ResolveFunction());
+      if (func.IsNull()) {
+        *error = strdup(zone.PrintToString(
+            "Internal error while starting isolate '%s': "
+            "unable to resolve entry function '%s'.",
+            child_isolate->name(), state->function_name()));
+        retval = false;
+      }
     }
   }
-  if (resolve_error) {
+  if (!retval) {
     Dart::ShutdownIsolate();
-    Isolate::SetCurrent(parent_isolate);
-    return false;
   }
-
   Isolate::SetCurrent(parent_isolate);
-  return true;
+  return retval;
 }
 
 
 static bool RunIsolate2(uword parameter) {
   Isolate* isolate = reinterpret_cast<Isolate*>(parameter);
   SpawnState* state = reinterpret_cast<SpawnState*>(isolate->spawn_data());
   isolate->set_spawn_data(NULL);
   {
     StartIsolateScope start_scope(isolate);
     Zone zone(isolate);
     HandleScope handle_scope(isolate);
     ASSERT(ClassFinalizer::FinalizePendingClasses());
     Object& result = Object::Handle();
 
-    result = state->ResolveFunction();
+    const Function& func = Function::Handle(state->ResolveFunction());
     delete state;
     state = NULL;
-    if (result.IsError()) {
-      StoreError(isolate, result);
-      return false;
-    }
-    ASSERT(result.IsFunction());
-    Function& func = Function::Handle(isolate);
-    func ^= result.raw();
+    ASSERT(!func.IsNull());
+
     GrowableArray<const Object*> args(0);
     const Array& kNoArgNames = Array::Handle();
     result = DartEntry::InvokeStatic(func, args, kNoArgNames);
     if (result.IsError()) {
       StoreError(isolate, result);
       return false;
     }
   }
   return true;
 }
 
 
-static void Spawn(NativeArguments* arguments, SpawnState* state) {
+DEFINE_NATIVE_ENTRY(isolate_spawnFunction, 1) {
+  GET_NATIVE_ARGUMENT(Closure, closure, arguments->At(0));
+  const Function& func = Function::Handle(closure.function());
+  const Class& cls = Class::Handle(func.owner());
+  if (!func.IsClosureFunction() || !func.is_static() || !cls.IsTopLevel()) {
+    const String& msg = String::Handle(String::New(
+        "spawnFunction expects to be passed a closure to a top-level static "
+        "function"));
+    ThrowIllegalArgException(msg);
+  }
+
+#if defined(DEBUG)
+  const Context& ctx = Context::Handle(closure.context());
+  ASSERT(ctx.num_variables() == 0);
+#endif
+
   // Create a new isolate.
   char* error = NULL;
+  SpawnState* state = new SpawnState(func);
   if (!CreateIsolate(state, &error)) {
     delete state;
     const String& msg = String::Handle(String::New(error));
-    free(error);
     ThrowIsolateSpawnException(msg);
   }
 
   // Try to create a SendPort for the new isolate.
   const Object& port = Object::Handle(
       DartLibraryCalls::NewSendPort(state->isolate()->main_port()));
   if (port.IsError()) {
     state->Cleanup();
     delete state;
     Exceptions::PropagateError(port);
   }
 
   // Start the new isolate.
   state->isolate()->set_spawn_data(reinterpret_cast<uword>(state));
   state->isolate()->message_handler()->Run(
       Dart::thread_pool(), RunIsolate2, ShutdownIsolate,
       reinterpret_cast<uword>(state->isolate()));
 
   arguments->SetReturn(port);
 }
 
 
-DEFINE_NATIVE_ENTRY(isolate_spawnFunction, 1) {
-  GET_NATIVE_ARGUMENT(Closure, closure, arguments->At(0));
-  const Function& func = Function::Handle(closure.function());
-  const Class& cls = Class::Handle(func.owner());
-  if (!func.IsClosureFunction() || !func.is_static() || !cls.IsTopLevel()) {
-    const String& msg = String::Handle(String::New(
-        "spawnFunction expects to be passed a closure to a top-level static "
-        "function"));
-    ThrowIllegalArgException(msg);
-  }
-
-#if defined(DEBUG)
-  const Context& ctx = Context::Handle(closure.context());
-  ASSERT(ctx.num_variables() == 0);
-#endif
-
-  Spawn(arguments, new SpawnState(func));
-}
-
-
-DEFINE_NATIVE_ENTRY(isolate_spawnUri, 1) {
-  GET_NATIVE_ARGUMENT(String, uri, arguments->At(0));
-
-  // Canonicalize the uri with respect to the current isolate.
-  char* error = NULL;
-  char* canonical_uri = NULL;
-  const Library& root_lib =
-      Library::Handle(arguments->isolate()->object_store()->root_library());
-  if (!CanonicalizeUri(arguments->isolate(), root_lib, uri,
-                       &canonical_uri, &error)) {
-    const String& msg = String::Handle(String::New(error));
-    free(error);
-    ThrowIsolateSpawnException(msg);
-  }
-
-  Spawn(arguments, new SpawnState(canonical_uri));
-}
-
-
 DEFINE_NATIVE_ENTRY(isolate_getPortInternal, 0) {
   const Object& port = Object::Handle(ReceivePortCreate(isolate->main_port()));
   if (port.IsError()) {
     Exceptions::PropagateError(port);
   }
   arguments->SetReturn(port);
 }
 
 }  // namespace dart