Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 10332255: Fix typos in field trial for low memory experiment. (Closed)

Created:
8 years, 7 months ago by Greg Spencer (Chromium)
Modified:
8 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix typos in field trial for low memory experiment. Somehow, I missed some typos in the settings for the experiment. Also fixed the multi-line macros to be safer if they were used without braces in an if clause. TBR=ben@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138501

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review changes #

Patch Set 3 : upload after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/oom_priority_manager.cc View 1 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 2 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Greg Spencer (Chromium)
8 years, 7 months ago (2012-05-20 15:42:22 UTC) #1
James Cook
LGTM with formatting nit -- choose whatever looks best to you. http://codereview.chromium.org/10332255/diff/1/chrome/browser/chromeos/oom_priority_manager.cc File chrome/browser/chromeos/oom_priority_manager.cc (right): ...
8 years, 7 months ago (2012-05-21 05:11:55 UTC) #2
James Cook
On 2012/05/21 05:11:55, James Cook (Chromium) wrote: > LGTM with formatting nit -- choose whatever ...
8 years, 7 months ago (2012-05-21 05:12:53 UTC) #3
Greg Spencer (Chromium)
It doesn't affect the running code, really, especially since the typo inserted the default value ...
8 years, 7 months ago (2012-05-21 16:48:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10332255/6001
8 years, 7 months ago (2012-05-21 17:41:07 UTC) #5
commit-bot: I haz the power
Presubmit check for 10332255-6001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-21 17:41:13 UTC) #6
Greg Spencer (Chromium)
I'm going to TBR the sad_tab_view.cc change, since it's so minor, and results in no ...
8 years, 7 months ago (2012-05-21 17:43:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10332255/6001
8 years, 7 months ago (2012-05-21 17:44:31 UTC) #8
commit-bot: I haz the power
Try job failure for 10332255-6001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-21 18:52:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10332255/6001
8 years, 7 months ago (2012-05-21 18:58:13 UTC) #10
commit-bot: I haz the power
Try job failure for 10332255-6001 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=12425 Step "update" is always ...
8 years, 7 months ago (2012-05-21 19:24:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10332255/1002
8 years, 7 months ago (2012-05-21 21:40:58 UTC) #12
commit-bot: I haz the power
Try job failure for 10332255-1002 (retry) on win_rel for steps "base_unittests, sync_unit_tests" (clobber build). It's ...
8 years, 7 months ago (2012-05-22 02:43:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10332255/1002
8 years, 7 months ago (2012-05-22 07:16:40 UTC) #14
commit-bot: I haz the power
Try job failure for 10332255-1002 (retry) (retry) (retry) on win_rel for step "compile" (clobber build). ...
8 years, 7 months ago (2012-05-22 12:00:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10332255/1002
8 years, 7 months ago (2012-05-22 13:53:49 UTC) #16
commit-bot: I haz the power
Try job failure for 10332255-1002 (retry) (retry) (retry) on win_rel for step "compile" (clobber build). ...
8 years, 7 months ago (2012-05-22 20:23:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10332255/1002
8 years, 7 months ago (2012-05-22 21:18:32 UTC) #18
commit-bot: I haz the power
Try job failure for 10332255-1002 (retry) on win_rel for step "sync_unit_tests" (clobber build). It's a ...
8 years, 7 months ago (2012-05-23 04:35:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/10332255/1002
8 years, 7 months ago (2012-05-23 07:07:30 UTC) #20
commit-bot: I haz the power
Try job failure for 10332255-1002 (retry) (retry) on win_rel for step "sync_unit_tests". It's a second ...
8 years, 7 months ago (2012-05-23 11:23:41 UTC) #21
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 15:44:56 UTC) #22

Powered by Google App Engine
This is Rietveld 408576698