gdata: Define the resource ID for the root directory

gdata: Define the resource ID for the root directory

Per the spec, the resource ID for the root directory is defined
as "folder:root". Add the resource ID to the root directory in our
file system representation so we can look up the root directory by
the resource ID.

BUG=127697
TEST=add unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137928

[achuithb, 2012-05-18 17:42:56]

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_files.cc (right):

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files.cc:875: const GDataEntryProto& entry =
proto->gdata_directory().gdata_entry();
nit: maybe call this entry_proto?

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_files_unittest.cc (right):

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:98: // root.resoruce_id()
should be unchanged.
resource_id

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:99:
ASSERT_FALSE(root.ParseFromString(serialized_proto));
I think EXPECT_FALSE is better here. I feel like ASSERT is only used if the
following lines will crash.

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:100:
ASSERT_EQ(kGDataRootDirectoryResourceId, root.resource_id());
EXPECT_EQ

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:104:
ASSERT_TRUE(proto.SerializeToString(&serialized_proto));
EXPECT_TRUE

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:107:
ASSERT_TRUE(root.ParseFromString(serialized_proto));
EXPECT_TRUE?

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:108:
ASSERT_EQ(kGDataRootDirectoryResourceId, root.resource_id());
EXPECT_EQ

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:116:
ASSERT_TRUE(entry->AsGDataRootDirectory());
EXPECT_TRUE

[satorux1, 2012-05-18 17:55:28]

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_files.cc (right):

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files.cc:875: const GDataEntryProto& entry =
proto->gdata_directory().gdata_entry();
On 2012/05/18 17:42:56, achuith.bhandarkar wrote:
> nit: maybe call this entry_proto?

Done.

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_files_unittest.cc (right):

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:98: // root.resoruce_id()
should be unchanged.
On 2012/05/18 17:42:56, achuith.bhandarkar wrote:
> resource_id

Done.

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:99:
ASSERT_FALSE(root.ParseFromString(serialized_proto));
On 2012/05/18 17:42:56, achuith.bhandarkar wrote:
> I think EXPECT_FALSE is better here. I feel like ASSERT is only used if the
> following lines will crash.

Won't crash but we don't want to continue if this failed. I'd keep this as
ASSERT.

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:100:
ASSERT_EQ(kGDataRootDirectoryResourceId, root.resource_id());
On 2012/05/18 17:42:56, achuith.bhandarkar wrote:
> EXPECT_EQ

Done.

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:104:
ASSERT_TRUE(proto.SerializeToString(&serialized_proto));
On 2012/05/18 17:42:56, achuith.bhandarkar wrote:
> EXPECT_TRUE

likewise, we don't want to continue if this failed.

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:107:
ASSERT_TRUE(root.ParseFromString(serialized_proto));
On 2012/05/18 17:42:56, achuith.bhandarkar wrote:
> EXPECT_TRUE?

ditto.

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:108:
ASSERT_EQ(kGDataRootDirectoryResourceId, root.resource_id());
On 2012/05/18 17:42:56, achuith.bhandarkar wrote:
> EXPECT_EQ

Done.

http://codereview.chromium.org/10332253/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_files_unittest.cc:116:
ASSERT_TRUE(entry->AsGDataRootDirectory());
On 2012/05/18 17:42:56, achuith.bhandarkar wrote:
> EXPECT_TRUE

Done.

[achuithb, 2012-05-18 18:01:06]

lgtm