Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 10332238: net-internals: Fix cookies not being hidden, when saving after capturing is stopped (Closed)

Created:
8 years, 7 months ago by mmenke
Modified:
8 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, tfarina, eroman, arv (Not doing code reviews)
Visibility:
Public.

Description

net-internals: Fix cookies not being hidden when clicking "stop loading" and then creating a log dump. Also fix a regression where we don't display a file name when loading a log dump. R=eroman@chromium.org BUG=128425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138489

Patch Set 1 #

Patch Set 2 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/browser/resources/net_internals/import_view.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/main.js View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/test/data/webui/net_internals/log_util.js View 1 6 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
8 years, 7 months ago (2012-05-22 21:23:16 UTC) #1
eroman
lgtm
8 years, 7 months ago (2012-05-22 21:25:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10332238/5001
8 years, 7 months ago (2012-05-22 21:26:56 UTC) #3
commit-bot: I haz the power
Try job failure for 10332238-5001 (retry) (retry) (retry) on win_rel for step "sync_unit_tests" (clobber build). ...
8 years, 7 months ago (2012-05-23 11:09:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10332238/5001
8 years, 7 months ago (2012-05-23 12:55:20 UTC) #5
commit-bot: I haz the power
Try job failure for 10332238-5001 (retry) on win_rel for step "sync_unit_tests". It's a second try, ...
8 years, 7 months ago (2012-05-23 16:15:31 UTC) #6
mmenke
8 years, 7 months ago (2012-05-23 16:21:15 UTC) #7
On 2012/05/23 16:15:31, I haz the power (commit-bot) wrote:
> Try job failure for 10332238-5001 (retry) on win_rel for step
"sync_unit_tests".
> It's a second try, previously, step "sync_unit_tests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Committed directly, as the CL has no effect on sync unit tests, and everything
else passed, both times.

Powered by Google App Engine
This is Rietveld 408576698