Issue 10332236: make: Support '#' characters in defines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332236: make: Support '#' characters in defines. (Closed)

Created:
8 years, 7 months ago by Nico

Modified:
8 years, 7 months ago

Reviewers:
Evan Martin

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

make: Support '#' characters in defines. TBR=evan Committed: https://code.google.com/p/gyp/source/detail?r=1386

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)			Patch
M	pylib/gyp/generator/make.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/defines/defines.c	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/defines/defines.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/defines/gyptest-defines.py	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Nico

8 years, 7 months ago (2012-05-18 03:27:19 UTC) #1

I'll tbr this because one of my bots is red because of this (yes, I need to move
it to ninja). The ninja generator doesn't have this problem.