Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: chrome/browser/extensions/extension_tab_helper.h

Issue 10332235: Make the page action space show extensions with active content scripts or (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tab_helper.h
diff --git a/chrome/browser/extensions/extension_tab_helper.h b/chrome/browser/extensions/extension_tab_helper.h
index 686d77d8b8499ad7d6bc59dc395ce4e8392e3b74..fcda259dec161c6128053e52eed80cd97c9e518d 100644
--- a/chrome/browser/extensions/extension_tab_helper.h
+++ b/chrome/browser/extensions/extension_tab_helper.h
@@ -27,6 +27,7 @@ struct LoadCommittedDetails;
namespace extensions {
class ActionBoxController;
+class ScriptBadgeController;
class ScriptExecutor;
}
@@ -109,13 +110,9 @@ class ExtensionTabHelper
return content::WebContentsObserver::web_contents();
}
- extensions::ScriptExecutor* script_executor() {
- return script_executor_.get();
- }
+ extensions::ScriptExecutor* script_executor();
- extensions::ActionBoxController* action_box_controller() {
- return action_box_controller_.get();
- }
+ extensions::ActionBoxController* action_box_controller();
// Sets a non-extension app icon associated with WebContents and fires an
// INVALIDATE_TYPE_TITLE navigation state change to trigger repaint of title.
@@ -203,9 +200,12 @@ class ExtensionTabHelper
TabContentsWrapper* wrapper_;
+ // Either script_executor/action_box_controller will have values, or
+ // script_badge_controller will have a value, depending on whether the action
+ // box is turned on.
scoped_ptr<extensions::ScriptExecutor> script_executor_;
-
scoped_ptr<extensions::ActionBoxController> action_box_controller_;
+ scoped_ptr<extensions::ScriptBadgeController> script_badge_controller_;
DISALLOW_COPY_AND_ASSIGN(ExtensionTabHelper);
};
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_tab_helper.cc » ('j') | chrome/browser/extensions/page_action_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698