Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Unified Diff: chrome/browser/extensions/page_action_controller.cc

Issue 10332235: Make the page action space show extensions with active content scripts or (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: oops iterator Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_action_controller.cc
diff --git a/chrome/browser/extensions/page_action_controller.cc b/chrome/browser/extensions/page_action_controller.cc
index ed3c8e67d540433c0a7839cbdc61be834f255d65..a8381e4a8af6c2d8c3f463c49e46921e8d44bb09 100644
--- a/chrome/browser/extensions/page_action_controller.cc
+++ b/chrome/browser/extensions/page_action_controller.cc
@@ -53,8 +53,8 @@ ActionBoxController::Action PageActionController::OnClicked(
int tab_id = ExtensionTabUtil::GetTabId(tab_contents_->web_contents());
switch (mouse_button) {
- case 1:
- case 2:
+ case 1: // left
+ case 2: // middle
if (page_action->HasPopup(tab_id))
return ACTION_SHOW_POPUP;
@@ -67,7 +67,7 @@ ActionBoxController::Action PageActionController::OnClicked(
mouse_button);
return ACTION_NONE;
- case 3:
+ case 3: // right
return extension->ShowConfigureContextMenus() ?
ACTION_SHOW_CONTEXT_MENU : ACTION_NONE;
}
« no previous file with comments | « chrome/browser/extensions/extension_tab_helper.cc ('k') | chrome/browser/extensions/script_badge_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698