Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 10332234: If getDaemonVersion() fails then log that the host version is not available. (Closed)

Created:
8 years, 7 months ago by Wez
Modified:
8 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

If getDaemonVersion() fails then log that the host version is not available. Without this, the web-app if the host plugin cannot be loaded. BUG=128586 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137822

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M remoting/webapp/host_controller.js View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
Wez
PTAL
8 years, 7 months ago (2012-05-18 01:08:11 UTC) #1
Jamie
lgtm https://chromiumcodereview.appspot.com/10332234/diff/1/remoting/webapp/host_controller.js File remoting/webapp/host_controller.js (right): https://chromiumcodereview.appspot.com/10332234/diff/1/remoting/webapp/host_controller.js#newcode30 remoting/webapp/host_controller.js:30: console.log('Host version not available.'); Optional: I think I'd ...
8 years, 7 months ago (2012-05-18 01:13:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10332234/1
8 years, 7 months ago (2012-05-18 01:30:56 UTC) #3
commit-bot: I haz the power
Try job failure for 10332234-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-18 02:46:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10332234/1
8 years, 7 months ago (2012-05-18 03:10:46 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-18 04:23:22 UTC) #6
Change committed as 137822

Powered by Google App Engine
This is Rietveld 408576698