Inherits SupportsWeakPtr<T> instead of having WeakPtrFactory<T>

Inherits SupportsWeakPtr<T> instead of having WeakPtrFactory<T>

This change refines r137676.

BUG=122654
TEST=browser_test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139771

[Takashi Toyoshima, 2012-05-30 12:17:03]

Hi Darin,

I forget to publish this review request.
This change fixes a worse design which you suggest in the review of
https://chromiumcodereview.appspot.com/10034017

Thanks and sorry for bothering.

[wtc, 2012-05-30 17:57:28]

Patch set 2 LGTM.  Please wait for Darin's review.

https://chromiumcodereview.appspot.com/10332233/diff/2001/content/browser/ren...
File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right):

https://chromiumcodereview.appspot.com/10332233/diff/2001/content/browser/ren...
content/browser/renderer_host/resource_dispatcher_host_impl.cc:1805:
global_id));

Nit: this fits on the previous line.  Or you may be able to
do this:
  base::Bind(&ResourceDispatcherHostImpl::ResumeRequest,
             AsWeakPtr(), global_id));

https://chromiumcodereview.appspot.com/10332233/diff/2001/content/browser/ren...
content/browser/renderer_host/resource_dispatcher_host_impl.cc:1922:
AsWeakPtr(), id));

Nit: this may fit on the previous line, or you may be able
to do this:
  base::Bind(&ResourceDispatcherHostImpl::ResumeRequest,
             AsWeakPtr(), id));

[darin (slow to review), 2012-05-30 20:11:40]

LGTM, thanks!

[Takashi Toyoshima, 2012-05-31 08:42:51]

Thank you, wtc and darin.
I'll submit this CL after fixing these two style nits.

https://chromiumcodereview.appspot.com/10332233/diff/2001/content/browser/ren...
File content/browser/renderer_host/resource_dispatcher_host_impl.cc (right):

https://chromiumcodereview.appspot.com/10332233/diff/2001/content/browser/ren...
content/browser/renderer_host/resource_dispatcher_host_impl.cc:1805:
global_id));
On 2012/05/30 17:57:28, wtc wrote:
> 
> Nit: this fits on the previous line.  Or you may be able to
> do this:
>   base::Bind(&ResourceDispatcherHostImpl::ResumeRequest,
>              AsWeakPtr(), global_id));

Done.

https://chromiumcodereview.appspot.com/10332233/diff/2001/content/browser/ren...
content/browser/renderer_host/resource_dispatcher_host_impl.cc:1922:
AsWeakPtr(), id));
On 2012/05/30 17:57:28, wtc wrote:
> 
> Nit: this may fit on the previous line, or you may be able
> to do this:
>   base::Bind(&ResourceDispatcherHostImpl::ResumeRequest,
>              AsWeakPtr(), id));

Done.

[commit-bot: I haz the power, 2012-05-31 08:43:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/10332233/8002

[commit-bot: I haz the power, 2012-05-31 11:01:48]

Change committed as 139771