Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7002)

Unified Diff: chrome/test/data/webui/certificate_viewer_ui_test-inl.h

Issue 10332231: Remove chrome::NOTIFICATION_WEB_DIALOG_SHOWN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add web_dialog_observer.h to chrome_browser.gypi Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/test_web_dialog_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/certificate_viewer_ui_test-inl.h
diff --git a/chrome/test/data/webui/certificate_viewer_ui_test-inl.h b/chrome/test/data/webui/certificate_viewer_ui_test-inl.h
index 28bac4cffa8042a7f7afe27ab6b7a6dd3d044db6..78949fe85dbd31f39b0bd166c6b4c1721fc45c2d 100644
--- a/chrome/test/data/webui/certificate_viewer_ui_test-inl.h
+++ b/chrome/test/data/webui/certificate_viewer_ui_test-inl.h
@@ -5,6 +5,7 @@
#include "chrome/browser/certificate_viewer.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/webui/certificate_viewer_webui.h"
#include "chrome/browser/ui/webui/web_ui_browsertest.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/test_web_dialog_observer.h"
@@ -34,7 +35,11 @@ void CertificateViewerUITest::ShowCertificateViewer() {
ASSERT_TRUE(browser()->window());
TestWebDialogObserver dialog_observer(this);
- ::ShowCertificateViewer(browser()->window()->GetNativeHandle(), google_cert);
+ CertificateViewerDialog* dialog = new CertificateViewerDialog(
+ google_cert);
+ dialog->AddObserver(&dialog_observer);
+ dialog->Show(browser()->window()->GetNativeHandle());
+ dialog->RemoveObserver(&dialog_observer);
content::WebUI* webui = dialog_observer.GetWebUI();
webui->GetWebContents()->GetRenderViewHost()->SetWebUIProperty(
"expectedUrl", chrome::kChromeUICertificateViewerURL);
« no previous file with comments | « chrome/test/base/test_web_dialog_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698