Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 10332231: Remove chrome::NOTIFICATION_WEB_DIALOG_SHOWN. (Closed)

Created:
8 years, 7 months ago by mazda
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove chrome::NOTIFICATION_WEB_DIALOG_SHOWN. This is a preliminary work for moving web dialog stuffs to ui/web_dialogs. BUG=125841 TEST=rowser_tests --gtest_filter="CertificateViewerUITest*.*" passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137979

Patch Set 1 #

Patch Set 2 : Add WebDialogObserver file #

Total comments: 1

Patch Set 3 : Add web_dialog_observer.h to chrome_browser.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -50 lines) Patch
M chrome/browser/ui/webui/certificate_viewer_webui.h View 1 4 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 1 3 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/web_dialog_delegate.h View 1 2 chunks +9 lines, -1 line 0 comments Download
A chrome/browser/ui/webui/web_dialog_observer.h View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/web_dialog_ui.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/base/test_web_dialog_observer.h View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/test/base/test_web_dialog_observer.cc View 4 chunks +19 lines, -21 lines 0 comments Download
M chrome/test/data/webui/certificate_viewer_ui_test-inl.h View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
mazda
Could you review this change? This is a preliminary work for moving web dialog code ...
8 years, 7 months ago (2012-05-17 23:56:42 UTC) #1
Ben Goodger (Google)
Cool! LGTM. Thanks for doing this.
8 years, 7 months ago (2012-05-18 15:52:13 UTC) #2
flackr
Cool, LGTM
8 years, 7 months ago (2012-05-18 16:37:22 UTC) #3
flackr
http://codereview.chromium.org/10332231/diff/7001/chrome/browser/ui/webui/web_dialog_delegate.h File chrome/browser/ui/webui/web_dialog_delegate.h (right): http://codereview.chromium.org/10332231/diff/7001/chrome/browser/ui/webui/web_dialog_delegate.h#newcode72 chrome/browser/ui/webui/web_dialog_delegate.h:72: content::RenderViewHost* render_view_host) {} It might make sense to have ...
8 years, 7 months ago (2012-05-18 16:44:19 UTC) #4
mazda
On 2012/05/18 16:44:19, flackr wrote: > http://codereview.chromium.org/10332231/diff/7001/chrome/browser/ui/webui/web_dialog_delegate.h > File chrome/browser/ui/webui/web_dialog_delegate.h (right): > > http://codereview.chromium.org/10332231/diff/7001/chrome/browser/ui/webui/web_dialog_delegate.h#newcode72 > ...
8 years, 7 months ago (2012-05-18 17:23:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10332231/13002
8 years, 7 months ago (2012-05-18 17:38:13 UTC) #6
commit-bot: I haz the power
Try job failure for 10332231-13002 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=12233 Step "update" is always ...
8 years, 7 months ago (2012-05-18 18:08:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10332231/13002
8 years, 7 months ago (2012-05-18 20:28:51 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-19 00:04:07 UTC) #9
Change committed as 137979

Powered by Google App Engine
This is Rietveld 408576698