Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 10332230: Run base_unittests_apk. (Closed)

Created:
8 years, 7 months ago by nilesh
Modified:
8 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Run base_unittests_apk on the test try bot for realz. This will make the android_test bot red when apk tests fail. The ANDROID_APK_TEST_TARGET flag is required while we transition from executable to APK tests. - Executable tests need the DIR_CACHE override as the default path comes from the java side. BUG=125059 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138407

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M base/test/test_stub_android.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M build/android/buildbot_functions.sh View 1 chunk +1 line, -9 lines 0 comments Download
M build/android/gtest_filter/base_unittests_disabled View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/run_tests.py View 1 1 chunk +2 lines, -5 lines 0 comments Download
M build/common.gypi View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
nilesh
8 years, 7 months ago (2012-05-18 02:05:43 UTC) #1
Yaron
lgtm
8 years, 7 months ago (2012-05-18 18:08:50 UTC) #2
nilesh
Adding base OWNERS.
8 years, 7 months ago (2012-05-18 18:16:02 UTC) #3
nilesh
8 years, 7 months ago (2012-05-21 19:15:56 UTC) #4
nilesh
8 years, 7 months ago (2012-05-22 01:13:03 UTC) #5
Paweł Hajdan Jr.
LGTM, I don't think you need so many reviewers. http://codereview.chromium.org/10332230/diff/11002/base/test/test_stub_android.cc File base/test/test_stub_android.cc (right): http://codereview.chromium.org/10332230/diff/11002/base/test/test_stub_android.cc#newcode147 base/test/test_stub_android.cc:147: ...
8 years, 7 months ago (2012-05-22 11:44:22 UTC) #6
nilesh
Thanks for the review. I added reviewers from base/OWNERS before noticing base/test/OWNERS http://codereview.chromium.org/10332230/diff/11002/base/test/test_stub_android.cc File base/test/test_stub_android.cc ...
8 years, 7 months ago (2012-05-22 16:43:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10332230/2003
8 years, 7 months ago (2012-05-22 16:46:06 UTC) #8
commit-bot: I haz the power
Try job failure for 10332230-2003 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 18:49:26 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 20:42:58 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698