Extends IBusText I/O function.

Extends IBusText I/O function.

Introduce AppendStringAsIBusText/PopStringFromIBusText utility functions to
handle string as IBusText, because there are many cases to handle IBusText as
simple string.

BUG=None
TEST=chromeos-unittests,unit_tests,ui_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137911

[satorux1, 2012-05-18 01:11:06]

http://codereview.chromium.org/10332228/diff/1/chromeos/dbus/ibus/ibus_text.cc
File chromeos/dbus/ibus/ibus_text.cc (right):

http://codereview.chromium.org/10332228/diff/1/chromeos/dbus/ibus/ibus_text.c...
chromeos/dbus/ibus/ibus_text.cc:167: text->assign(ibus_text.text());
Should we do this when |result| is false?

Maybe:

if (PopIBusText(reader, &ibus_text)) {
  *text = ibus_text.text()
  return true;
}
return false;

http://codereview.chromium.org/10332228/diff/1/chromeos/dbus/ibus/ibus_text.h
File chromeos/dbus/ibus/ibus_text.h (right):

http://codereview.chromium.org/10332228/diff/1/chromeos/dbus/ibus/ibus_text.h...
chromeos/dbus/ibus/ibus_text.h:87: // Return false if an error occures.
// Returns true on success.

[Seigo Nonaka, 2012-05-18 01:18:43]

https://chromiumcodereview.appspot.com/10332228/diff/1/chromeos/dbus/ibus/ibu...
File chromeos/dbus/ibus/ibus_text.cc (right):

https://chromiumcodereview.appspot.com/10332228/diff/1/chromeos/dbus/ibus/ibu...
chromeos/dbus/ibus/ibus_text.cc:167: text->assign(ibus_text.text());
Done
On 2012/05/18 01:11:06, satorux1 wrote:
> Should we do this when |result| is false?
> 
> Maybe:
> 
> if (PopIBusText(reader, &ibus_text)) {
>   *text = ibus_text.text()
>   return true;
> }
> return false;

https://chromiumcodereview.appspot.com/10332228/diff/1/chromeos/dbus/ibus/ibu...
File chromeos/dbus/ibus/ibus_text.h (right):

https://chromiumcodereview.appspot.com/10332228/diff/1/chromeos/dbus/ibus/ibu...
chromeos/dbus/ibus/ibus_text.h:87: // Return false if an error occures.
On 2012/05/18 01:11:06, satorux1 wrote:
> // Returns true on success.

Done.

[satorux1, 2012-05-18 01:26:30]

LGTM

[commit-bot: I haz the power, 2012-05-18 17:04:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/10332228/5001

[commit-bot: I haz the power, 2012-05-18 18:31:48]

Change committed as 137911