Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 10332218: Fix temp dir path for Android. (Closed)

Created:
8 years, 7 months ago by nilesh
Modified:
8 years, 7 months ago
Reviewers:
Mark Mentovai, Yaron
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Fix temp dir path for Android. "/data/local/tmp" is not writable by applications. BUG=125059 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/file_util_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/file_util_posix.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nilesh
8 years, 7 months ago (2012-05-17 16:37:24 UTC) #1
Yaron
lgtm
8 years, 7 months ago (2012-05-17 16:50:35 UTC) #2
Mark Mentovai
LGTM for OWNERS approval only. Yaron can say whether DIR_CACHE is appropriate for this task ...
8 years, 7 months ago (2012-05-17 17:27:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10332218/1
8 years, 7 months ago (2012-05-17 18:44:15 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 20:09:10 UTC) #5
Change committed as 137719

Powered by Google App Engine
This is Rietveld 408576698