Issue 10332209: Fix the path to native_theme_resources.rc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10332209: Fix the path to native_theme_resources.rc (Closed)

Created:
8 years, 7 months ago by oshima

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the path to native_theme_resources.rc TBR=ben@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137531

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/aura/aura.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 7 months ago (2012-05-16 22:13:31 UTC) #2

LGTM

On Wed, May 16, 2012 at 3:04 PM, <oshima@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Fix the path to native_theme_resources.rc
>
> TBR=ben@chromium.org
> BUG=none
> TEST=none
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=137531<https://src.chromium.org/viewvc/chrome?view=rev&revision=137531>
>
> Please review this at
http://codereview.chromium.**org/10332209/<http://codereview.chromium.org/103...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/aura/aura.gyp
>
>
> Index: ui/aura/aura.gyp
> diff --git a/ui/aura/aura.gyp b/ui/aura/aura.gyp
> index c9716f98e211a75bed8ee7084060a5**6409112ce2..**
> e53782a025fca1ebd124bfcadea77e**856032f504 100644
> --- a/ui/aura/aura.gyp
> +++ b/ui/aura/aura.gyp
> @@ -213,7 +213,7 @@
>       ],
>       'sources': [
>         'demo/demo_main.cc',
> -        '<(SHARED_INTERMEDIATE_DIR)/**ui/base/native_theme/native_**
> theme_resources.rc',
> +        '<(SHARED_INTERMEDIATE_DIR)/**ui/native_theme/native_theme_**
> resources.rc',
>         '<(SHARED_INTERMEDIATE_DIR)/**ui/ui_resources/ui_resources.**rc',
>       ],
>     },
>
>
>

Expand Messages | Collapse Messages