Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 10332207: Merge 137377 - Show the message 'No files match "abc"' if the search results are empty. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1132/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/file_manager.js
===================================================================
--- chrome/browser/resources/file_manager/js/file_manager.js (revision 137481)
+++ chrome/browser/resources/file_manager/js/file_manager.js (working copy)
@@ -4372,15 +4372,31 @@
};
FileManager.prototype.onSearchBoxUpdate_ = function(event) {
- var searchString = this.dialogDom_.querySelector('#search-box').value;
+ var searchString = this.document_.getElementById('search-box').value;
+ var searchStringLC = searchString.toLowerCase();
+ var noResultsDiv = this.document_.getElementById('no-search-results');
if (searchString) {
this.directoryModel_.addFilter(
'searchbox',
function(e) {
- return e.name.substr(0, searchString.length) == searchString;
+ return e.name.toLowerCase().indexOf(searchStringLC) > -1;
});
+
+ this.reportEmptySearchResults_ = function() {
+ if (this.directoryModel_.getFileList().length === 0) {
+ var text = strf('SEARCH_NO_MATCHING_FILES', searchString);
+ noResultsDiv.innerHTML = text;
+ noResultsDiv.hidden = false;
+ }
+ }.bind(this);
+
+ this.directoryModel_.addEventListener(
+ 'rescan-completed', this.reportEmptySearchResults_);
} else {
this.directoryModel_.removeFilter('searchbox');
+ noResultsDiv.hidden = true;
+ this.directoryModel_.removeEventListener(
+ 'rescan-completed', this.reportEmptySearchResults_);
}
};
« no previous file with comments | « chrome/browser/resources/file_manager/css/file_manager.css ('k') | chrome/browser/resources/file_manager/js/mock_chrome.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698