Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10332207: Merge 137377 - Show the message 'No files match "abc"' if the search results are empty. (Closed)

Created:
8 years, 7 months ago by satorux1
Modified:
8 years, 7 months ago
Reviewers:
Oleg Eterevsky
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Merge 137377 - Show the message 'No files match "abc"' if the search results are empty. Make search case-insensitive. Match files by extensions and other substrings. BUG=126633, 126704, 126993 TEST="The message is shown in place of file list if the search results are empty." Review URL: https://chromiumcodereview.appspot.com/10388142 TBR=oleg@chromium.org NOTE: Edited file_manager.css manually as there was a minor conflict caused by r136767 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +18 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
8 years, 7 months ago (2012-05-16 19:31:43 UTC) #1
Oleg Eterevsky
8 years, 7 months ago (2012-05-18 08:47:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698