Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 10332205: Fix logging of string16s from gfx namespace on Windows. (Closed)

Created:
8 years, 7 months ago by Alexei Svitkine (slow)
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Fix logging of string16s from gfx namespace on Windows. I don't why this fixes it, but somehow having a SelectionModel << logging operator in the gfx namespace makes Visual Studio fail to find the << logging operator for string16 arguments. Per discussion with Scott, we decided to remove the << operators altogether and replace them with a ToString() function to be consistent with Rect, Size, etc. TEST=Check that adding a "LOG(INFO) << text();" line to RenderTextWin compiles. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137732

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M ui/base/range/range.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/range/range.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ui/gfx/render_text.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M ui/gfx/selection_model.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M ui/gfx/selection_model.cc View 1 2 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexei Svitkine (slow)
8 years, 7 months ago (2012-05-16 19:23:02 UTC) #1
sky
How about a ToString method instead?
8 years, 7 months ago (2012-05-16 21:29:41 UTC) #2
Alexei Svitkine (slow)
Done and also the same for Range. I actually argued for this on the code ...
8 years, 7 months ago (2012-05-17 15:45:50 UTC) #3
sky
LGTM
8 years, 7 months ago (2012-05-17 16:18:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10332205/6002
8 years, 7 months ago (2012-05-17 19:17:11 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 20:53:17 UTC) #6
Change committed as 137732

Powered by Google App Engine
This is Rietveld 408576698