SelectAll when activating the omni box via touch. Regular (short) touch should now work the same wa…

SelectAll when activating the omni box via touch. Regular (short) touch should now work the same way as mouse left click and a long press the same as right click.

BUG=127293
TEST=Activate the omni box via touch.  All the text in the omni box should be selected.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137510

[Peter Kasting, 2012-05-16 18:30:16]

LGTM, somewhat rubber-stamp since I don't really understand all the relevant
messages.

We also have double- and triple-click handling code that keys off handlers like
OnLButtonDown(), OnLButtonDblClk(), etc.  Do we need to update these or other
places for touch-based messages as well?

https://chromiumcodereview.appspot.com/10332197/diff/5001/chrome/browser/ui/v...
File chrome/browser/ui/views/omnibox/omnibox_view_win.cc (right):

https://chromiumcodereview.appspot.com/10332197/diff/5001/chrome/browser/ui/v...
chrome/browser/ui/views/omnibox/omnibox_view_win.cc:61: // TODO(tommi): Remove
this when we update to a newer SDK.
Just curious: Is there a bug or specific plan on updating to a newer SDK?  It'd
be nice to do that soon so these sorts of blobs don't proliferate.

https://chromiumcodereview.appspot.com/10332197/diff/5001/chrome/browser/ui/v...
chrome/browser/ui/views/omnibox/omnibox_view_win.cc:1681: if (result ==
MA_ACTIVATE &&
Nit: For consistency with the rest of this file, keep each binary-op expr in
parens.

Any particular reason to reverse the condition ordering?  Both seem about the
same to me.

[tommi (sloooow) - chröme, 2012-05-16 19:11:07]

Re: double and triple clicks, they now work the same way with touch as with the
mouse.

https://chromiumcodereview.appspot.com/10332197/diff/5001/chrome/browser/ui/v...
File chrome/browser/ui/views/omnibox/omnibox_view_win.cc (right):

https://chromiumcodereview.appspot.com/10332197/diff/5001/chrome/browser/ui/v...
chrome/browser/ui/views/omnibox/omnibox_view_win.cc:61: // TODO(tommi): Remove
this when we update to a newer SDK.
On 2012/05/16 18:30:16, Peter Kasting wrote:
> Just curious: Is there a bug or specific plan on updating to a newer SDK? 
It'd
> be nice to do that soon so these sorts of blobs don't proliferate.

I don't know if there is a bug filed, but we're already starting to look into
the latest platform sdk (8) so I think that will happen regardless.  Hmm...
maybe I should keep this in the header where there's another similar check, just
to keep the number of blobs down?

https://chromiumcodereview.appspot.com/10332197/diff/5001/chrome/browser/ui/v...
chrome/browser/ui/views/omnibox/omnibox_view_win.cc:1681: if (result ==
MA_ACTIVATE &&
On 2012/05/16 18:30:16, Peter Kasting wrote:
> Nit: For consistency with the rest of this file, keep each binary-op expr in
> parens.
> 

Done

> Any particular reason to reverse the condition ordering?  Both seem about the
> same to me.

No reason. They got shifted around while debugging.
I switched them back for a simpler diff.

[Peter Kasting, 2012-05-16 19:12:34]

https://chromiumcodereview.appspot.com/10332197/diff/5001/chrome/browser/ui/v...
File chrome/browser/ui/views/omnibox/omnibox_view_win.cc (right):

https://chromiumcodereview.appspot.com/10332197/diff/5001/chrome/browser/ui/v...
chrome/browser/ui/views/omnibox/omnibox_view_win.cc:61: // TODO(tommi): Remove
this when we update to a newer SDK.
On 2012/05/16 19:11:08, tommi wrote:
> On 2012/05/16 18:30:16, Peter Kasting wrote:
> > Just curious: Is there a bug or specific plan on updating to a newer SDK? 
> It'd
> > be nice to do that soon so these sorts of blobs don't proliferate.
> 
> I don't know if there is a bug filed, but we're already starting to look into
> the latest platform sdk (8) so I think that will happen regardless.  Hmm...
> maybe I should keep this in the header where there's another similar check,
just
> to keep the number of blobs down?

That'd be fine.  Whatever you think is best.

I mostly just want to make sure that we don't lose track of any of these blobs,
so they don't live any longer than they have to.

[commit-bot: I haz the power, 2012-05-16 19:25:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommi@chromium.org/10332197/8002

[commit-bot: I haz the power, 2012-05-16 21:07:12]

Change committed as 137510