Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 10332185: Update behavior of one-click infobar to remove modal dialog, add "undo". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
index 11c41ac1019bf3b7161f1c0852c298b6eee691b2..29baed146164e547578e3f2d3d73e5342d941367 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
@@ -19,14 +19,15 @@ OneClickSigninSyncStarter::OneClickSigninSyncStarter(
const std::string& session_index,
const std::string& email,
const std::string& password,
- bool use_default_settings)
+ StartSyncMode start_mode)
: profile_(profile),
signin_tracker_(profile, this),
- use_default_settings_(use_default_settings) {
+ start_mode_(start_mode) {
DCHECK(profile_);
- int action = use_default_settings ? one_click_signin::HISTOGRAM_WITH_DEFAULTS
- : one_click_signin::HISTOGRAM_WITH_ADVANCED;
+ int action = start_mode_ == SYNC_WITH_DEFAULT_SETTINGS ?
+ one_click_signin::HISTOGRAM_WITH_DEFAULTS :
+ one_click_signin::HISTOGRAM_WITH_ADVANCED;
UMA_HISTOGRAM_ENUMERATION("AutoLogin.Reverse", action,
one_click_signin::HISTOGRAM_MAX);
@@ -57,7 +58,7 @@ void OneClickSigninSyncStarter::SigninSuccess() {
ProfileSyncService* profile_sync_service =
ProfileSyncServiceFactory::GetForProfile(profile_);
- if (use_default_settings_) {
+ if (start_mode_ == SYNC_WITH_DEFAULT_SETTINGS) {
// Just kick off the sync machine, no need to configure it first.
profile_sync_service->SetSyncSetupCompleted();
profile_sync_service->set_setup_in_progress(false);
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_starter.h ('k') | chrome/browser/ui/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698